Remove SampleLegacyModule from RNTester#55991
Open
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Open
Remove SampleLegacyModule from RNTester#55991christophpurrer wants to merge 1 commit intofacebook:mainfrom
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95684553. |
Summary: The `SampleLegacyModule` was a sample module used to demonstrate the legacy (non-TurboModule) native module API. Since React Native has fully migrated to TurboModules, this legacy sample module is no longer needed. This removes: - `SampleLegacyModule.kt` (Android platform implementation) - `RCTSampleLegacyModule.h/mm` (iOS platform implementation) - `LegacyModuleExample.js` and `SampleLegacyModuleExample.js` (JS example screens) - All references from `RNTesterApplication.kt`, `CatalystApplication.java`, and RNTester list files - E2E test for SampleLegacyModule ## Changelog: [General] [Removed] - Remove SampleLegacyModule from RNTester Differential Revision: D95684553
christophpurrer
force-pushed
the
export-D95684553
branch
from
b2703ba to
b6a2bbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
SampleLegacyModulewas a sample module used to demonstrate the legacy (non-TurboModule) native module API. Since React Native has fully migrated to TurboModules, this legacy sample module is no longer needed.This removes:
SampleLegacyModule.kt(Android platform implementation)RCTSampleLegacyModule.h/mm(iOS platform implementation)LegacyModuleExample.jsandSampleLegacyModuleExample.js(JS example screens)RNTesterApplication.kt,CatalystApplication.java, and RNTester list filesChangelog:
[General] [Removed] - Remove SampleLegacyModule from RNTester
Differential Revision: D95684553