Bring back C++ Turbo Module example in RN Tester#55988
Closed
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Closed
Bring back C++ Turbo Module example in RN Tester#55988christophpurrer wants to merge 1 commit intofacebook:mainfrom
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: ## Changelog: [General] [Fixed] - Bring back C++ Turbo Module example in RN Tester The `TurboCxxModuleExample` was accidentally deleted in facebook#54544 (D87082461) which removed the TurboCxxModule C++ class. The JS example file and its RN Tester registrations should have been kept since they wrap `NativeCxxModuleExampleExample` which still exists. This restores: - `TurboCxxModuleExample.js` example file - RNTesterList entries for iOS, Android, macOS, and Windows Differential Revision: D95653981
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95653981. |
meta-cla
bot
added
the
CLA Signed
Collaborator
|
This pull request was successfully merged by @christophpurrer in 1c2cdda When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General] [Fixed] - Bring back C++ Turbo Module example in RN Tester
The
TurboCxxModuleExamplewas accidentally deleted in #54544 (D87082461) which removed the TurboCxxModule C++ class. The JS example file and its RN Tester registrations should have been kept since they wrapNativeCxxModuleExampleExamplewhich still exists.This restores:
TurboCxxModuleExample.jsexample fileDifferential Revision: D95653981