Fix MissingOverrideAnnotation: Add @Override to setLetterSpacing in ReactTextView#55984
Closed
mdvacca wants to merge 4 commits intofacebook:mainfrom
Closed
Fix MissingOverrideAnnotation: Add @Override to setLetterSpacing in ReactTextView#55984mdvacca wants to merge 4 commits intofacebook:mainfrom
mdvacca wants to merge 4 commits intofacebook:mainfrom
Conversation
…tRootViewTag (facebook#55980) Summary: Fixed MissingOverrideAnnotation lint errors in ReactRootView.java. Added Override annotation to getRootViewTag() and setRootViewTag() methods which override methods from a superclass but were missing the annotation. changelog: [internal] internal Differential Revision: D95412652
…ds (facebook#55981) Summary: Fixed MissingOverrideAnnotation lint errors in UIManagerModule.java. Added Override annotation to sendAccessibilityEvent(), addUIManagerEventListener(), removeUIManagerEventListener(), and updateRootLayoutSpecs() methods which override methods from a superclass but were missing the annotation. changelog: [internal] internal Differential Revision: D95412726
…acebook#55983) Summary: Fixed MissingOverrideAnnotation lint errors in ReactHorizontalScrollView.java and ReactScrollView.java. Added Override annotation to getScrollEnabled(), reactSmoothScrollTo(), and getStateWrapper() methods in both scroll view implementations, keeping them in sync as required. changelog: [internal] internal Differential Revision: D95412846
…eactTextView Summary: Fixed MissingOverrideAnnotation lint error in ReactTextView.java. Added Override annotation to setLetterSpacing() method which overrides a method from a superclass but was missing the annotation. changelog: [internal] internal Differential Revision: D95412892
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 5ba0a1b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed MissingOverrideAnnotation lint error in ReactTextView.java.
Added Override annotation to setLetterSpacing() method which overrides a method from a superclass but was missing the annotation.
changelog: [internal] internal
Differential Revision: D95412892