Setup node in the linter for test all#55907
Closed
cipolleschi wants to merge 1 commit intofacebook:mainfrom
Closed
Setup node in the linter for test all#55907cipolleschi wants to merge 1 commit intofacebook:mainfrom
cipolleschi wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95204543. |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 4, 2026
…ebook#55907) Summary: Github OSS CI is failing because of D95055797. Reverting the diff to fix the OSS CI ## Changelog: [Internal] - Reviewed By: lenaic Differential Revision: D95204543
def957a to
dc79c57
Compare
…ebook#55907) Summary: Github OSS CI is failing because of D95055797. Reverting the diff to fix the OSS CI ## Changelog: [Internal] - Reviewed By: lenaic Differential Revision: D95204543
dc79c57 to
f010612
Compare
This was referenced Mar 4, 2026
|
This pull request has been merged in b4a3544. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in b4a3544 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Github OSS CI is failing because of D95055797.
The reason is that the lint job is still using node 20 as default, but from 0.84 we should use 22.
This change should fix CI
Changelog:
[Internal] -
Differential Revision: D95204543