Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -352,5 +352,41 @@ describe('react-native-babel-preset transform snapshots', () => {
expect(result).toContain('import');
expect(result).toContain('export');
});

it('preserves private class fields with unstable_preserveClassPrivate', () => {
const code = `
class Counter {
#count = 0;
#privateMethod() { return this.#count; }
increment() { this.#count++; }
}
`;
const result = transformCode(code, {
dev: false,
unstable_transformProfile: 'hermes-stable',
customTransformOptions: {
unstable_preserveClassPrivate: true,
},
});
expect(result).toContain('#count');
expect(result).toContain('#privateMethod');
});

it('transforms private class fields without unstable_preserveClassPrivate', () => {
const code = `
class Counter {
#count = 0;
#privateMethod() { return this.#count; }
increment() { this.#count++; }
}
`;
const result = transformCode(code, {
dev: false,
unstable_transformProfile: 'hermes-stable',
});
expect(result).not.toContain('#count');
expect(result).not.toContain('#privateMethod');
expect(result).toContain('_classPrivateFieldLooseKey');
});
});
});
23 changes: 18 additions & 5 deletions packages/react-native-babel-preset/src/configs/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ const EXCLUDED_FIRST_PARTY_PATHS = [
/[/\\]private[/\\]react-native-fantom[/\\]/,
];

// customTransformOptions may be strings from URL params, or booleans passed
// programatically. For strings, handle them as Metro does when parsing URLs.
const TRUE_VALS = new Set([true, 'true', '1']);

function isTypeScriptSource(fileName) {
return !!fileName && fileName.endsWith('.ts');
}
Expand Down Expand Up @@ -73,6 +77,11 @@ const getPreset = (src, options, babel) => {
// Preserve class syntax and related if we're using Hermes V1.
const preserveClasses = isHermesV1;

// Preserve private class fields and methods if the experiment is enabled.
const preserveClassPrivate = TRUE_VALS.has(
options?.customTransformOptions?.unstable_preserveClassPrivate,
);

const isNull = src == null;
const hasClass = isNull || src.indexOf('class') !== -1;

Expand Down Expand Up @@ -217,11 +226,15 @@ const getPreset = (src, options, babel) => {
...(preserveClasses
? []
: [[require('@babel/plugin-transform-class-properties'), {loose}]]),
[require('@babel/plugin-transform-private-methods'), {loose}],
[
require('@babel/plugin-transform-private-property-in-object'),
{loose},
],
...(preserveClassPrivate
? []
: [
[require('@babel/plugin-transform-private-methods'), {loose}],
[
require('@babel/plugin-transform-private-property-in-object'),
{loose},
],
]),
[require('@babel/plugin-syntax-dynamic-import')],
[require('@babel/plugin-syntax-export-default-from')],
...passthroughSyntaxPlugins,
Expand Down
Loading