Skip to content

Player: Move and slide in physics process#2030

Merged
wjt merged 1 commit intomainfrom
fix-player-physics-process
Mar 6, 2026
Merged

Player: Move and slide in physics process#2030
wjt merged 1 commit intomainfrom
fix-player-physics-process

Conversation

@manuq
Copy link
Collaborator

@manuq manuq commented Mar 6, 2026

Change the player and player_hook scripts to move and slide the player in _physics_process(), rather than in _process().

Fix #2025

Change the player and player_hook scripts to move and slide the player in `_physics_process()`, rather than in `_process()`.
@manuq
Copy link
Collaborator Author

manuq commented Mar 6, 2026

recording.webm

The video shows gameplay at normal speed, then at 4x, and then at 16x. I haven't seen any issues. But since this changes player, a full playthough is necessary.

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Play this branch at https://play.threadbare.game/branches/endlessm/fix-player-physics-process.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@manuq
Copy link
Collaborator Author

manuq commented Mar 6, 2026

I wonder if this was also the actual cause of the player getting stuck in tile corners or trees, for which we changed the wall min slide angle in 9943f36 from 15 (default) to 1 degree. That one had the consequence of the player sliding way too much on walls, like when grappling:

Grabacion.de.pantalla.desde.2026-03-06.10-22-48.mp4

@manuq manuq marked this pull request as ready for review March 6, 2026 13:28
@manuq manuq requested a review from a team as a code owner March 6, 2026 13:28
@manuq
Copy link
Collaborator Author

manuq commented Mar 6, 2026

I did a playthough of the first 2 lore quests (not StoryQuests or placeholder quest) and couldn't find any issues.

@wjt
Copy link
Member

wjt commented Mar 6, 2026

I wonder if this was also the actual cause of the player getting stuck in tile corners or trees, for which we changed the wall min slide angle in 9943f36 from 15 (default) to 1 degree.

Good question! We could try reverting it?

@wjt wjt merged commit a77370c into main Mar 6, 2026
6 checks passed
@wjt wjt deleted the fix-player-physics-process branch March 6, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grappling Hook: Player or buttons may get stuck on pins/needles

2 participants