Najju final final finalito

[Neitan501]

Terminado

[manuq]

@Neitan501 ¡hola! Creo que estás intentando abrir un pull request contra https://github.com/grupo-media-docena/threadbare/tree/najju_final_2 en vez de enviarla al repositorio principal. El paso 6 de la guía #599 dice que hay que cambiar el repositorio base para que sea tu repositorio (es decir el de tu grupo). Por lo tanto voy a cerrar este pull request. ¡Buena suerte con tu story quest!
/
Hi! I think that you meant to open this pull request against https://github.com/grupo-media-docena/threadbare/tree/najju_final_2 instead of sending it to the main repository. Step 6 of the guide #599 tells to change the base repository to be your repository (that is your group's repository). So I'm going to close this pull request. Good luck with your story quest!

[wjt]

If you intend to submit this StoryQuest upstream in future, there are some changes that will be needed. I have noted them here for your information!

[wjt]

If you intend to submit this StoryQuest upstream in future, you will need to revert these changes to the shared rock scene. You can duplicate this scene into your storyquest folder, update your scenes to use it, and revert your changes here.

[wjt]

I think this was not intended: this is the intro dialogue shown at the very start of the game. You have later updated cuy_play_intro.dialogue so this should be reverted.

[wjt]

I don't think you intended to have translations for those files?

Suggested change

locale/translations=PackedStringArray("res://locale/es.po", "res://scenes/quests/story_quests/cuy_play/3_sequence_puzzle/cuy_play_sequence_puzzle.en.translation", "res://scenes/quests/story_quests/cuy_play/3_sequence_puzzle/intro.en.translation", "res://scenes/quests/story_quests/cuy_play/3_sequence_puzzle/cuy_play_intro.en.translation", "res://scenes/quests/story_quests/cuy_play/3_sequence_puzzle/cuy_play_outro.en.translation")

locale/translations=PackedStringArray("res://locale/es.po")

[wjt]

Please move this and other files that you have added to the root folder of the project into your storyquest folder.