Skip to content

Add family for reconciler jobs#3769

Merged
trancexpress merged 2 commits intoeclipse-platform:masterfrom
trancexpress:gh3768
Mar 9, 2026
Merged

Add family for reconciler jobs#3769
trancexpress merged 2 commits intoeclipse-platform:masterfrom
trancexpress:gh3768

Conversation

@trancexpress
Copy link
Contributor

Fixes: #3768

@trancexpress
Copy link
Contributor Author

Change in the test would then be:

diff --git a/org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/SaveParticipantTest.java b/org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/SaveParticipantTest.java
index 2073bebad9..a1a69bee39 100644
--- a/org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/SaveParticipantTest.java
+++ b/org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/SaveParticipantTest.java
@@ -25,10 +25,11 @@ import org.junit.runners.Parameterized;
 import org.junit.runners.Parameterized.Parameters;
 
 import org.eclipse.core.runtime.CoreException;
+import org.eclipse.core.runtime.jobs.Job;
 import org.eclipse.core.runtime.preferences.IEclipsePreferences;
 import org.eclipse.core.runtime.preferences.InstanceScope;
 
-import org.eclipse.ui.PartInitException;
+import org.eclipse.jface.internal.text.reconciler.ReconcilerJobFamilies;
 
 import org.eclipse.jdt.core.IClasspathEntry;
 import org.eclipse.jdt.core.ICompilationUnit;
@@ -80,8 +81,10 @@ public class SaveParticipantTest extends CleanUpTestCase {
                TestUtils.waitForIndexer();
        }
 
-       private static void editCUInEditor(ICompilationUnit cu, String newContent) throws JavaModelException, PartInitException {
+       @SuppressWarnings("restriction")
+       private static void editCUInEditor(ICompilationUnit cu, String newContent) throws Exception {
                JavaEditor editor= (JavaEditor) EditorUtility.openInEditor(cu);
+               Job.getJobManager().join(ReconcilerJobFamilies.FAMILY_RECONCILER, null);
 
                cu.getBuffer().setContents(newContent);
                editor.doSave(null);

We could add the wait to other callers too, but lets see waiting will fix anything.

@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Mar 9, 2026

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From d7de96e59adad6c53368e182a1a1ba0f5063607a Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Mon, 9 Mar 2026 18:49:27 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF b/bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF
index 785c52169b..fe46a55bb3 100644
--- a/bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jface.text
-Bundle-Version: 3.30.0.qualifier
+Bundle-Version: 3.30.100.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: 
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Test Results

   852 files  ±0     852 suites  ±0   53m 58s ⏱️ -56s
 7 848 tests ±0   7 605 ✅ ±0  243 💤 ±0  0 ❌ ±0 
20 070 runs  ±0  19 414 ✅ ±0  656 💤 ±0  0 ❌ ±0 

Results for commit f8e3b92. ± Comparison against base commit 300659d.

♻️ This comment has been updated with latest results.

@trancexpress
Copy link
Contributor Author

@iloveeclipse anything against merging this?

@trancexpress
Copy link
Contributor Author

Caused by: java.io.IOException: Server returned HTTP code: 502 for URL https://download.eclipse.org/eclipse/updates/4.39-I-builds/I20260226-0420/plugins/com.ibm.icu.source_78.2.0.jar

@trancexpress trancexpress merged commit a39ccc6 into eclipse-platform:master Mar 9, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add family for reconciler jobs

3 participants