Show ZWSP (zero width space) as code mining by marcushoepfner · Pull Request #1437 · eclipse-platform/eclipse.platform.ui

marcushoepfner · 2023-12-19T15:41:38Z

For more information refer to https://www.compart.com/en/unicode/U+200B To get a ZWSP refer to https://zerowidthspace.me/

...r/src/org/eclipse/ui/internal/texteditor/codemining/ZeroWidthSpaceLineContentCodeMining.java

github-actions · 2023-12-19T16:20:22Z

Test Results

852 files ±0 852 suites ±0 53m 43s ⏱️ - 3m 5s
7 844 tests ±0 7 601 ✅ +1 243 💤 ±0 0 ❌ - 1
20 058 runs ±0 19 402 ✅ +1 656 💤 ±0 0 ❌ - 1

Results for commit a0b6352. ± Comparison against base commit b819cf9.

♻️ This comment has been updated with latest results.

BeckerWdf · 2023-12-20T07:34:19Z

I did a quick manual test on macOS. I found the following issues:

code mining is not displayed emidiately. I have to close and reopen the editor for the code minings to be shown
Two ZWSP next to each other are drawn one the (almost?) same location. See line 4 in:

When select the "a" and the "ZWSP" in line 2 from the above screenshot to with the keyboard I have to press the right-cursor two times until the caret is behind the "ZWSP".

...g/eclipse/ui/internal/texteditor/codemining/ZeroWidthSpaceLineContentCodeMiningProvider.java

BeckerWdf · 2025-08-13T07:42:34Z

I manually tested your change.

the ZWSP is shown correctly:

but when I disable the "show whitespace character" function (e.g. via the toolbar button) the ZWSP code mining still not disappears (even though the other "white space character" stuff does correctly disappear:

BeckerWdf

See my comments above

BeckerWdf · 2025-08-13T07:46:36Z

another topic:
a user can change the color of the code minings in the "fonts and colors" preference page. If you do this you will see a mix of colors:

Maybe this can be improved:

either by ignoring the users color pref here
also use the code mining color from preferences for the other "white space character" drawing logic.

marcushoepfner · 2025-10-09T13:05:17Z

I manually tested your change.

the ZWSP is shown correctly:

but when I disable the "show whitespace character" function (e.g. via the toolbar button) the ZWSP code mining still not disappears (even though the other "white space character" stuff does correctly disappear:

fixed with the last commit.

marcushoepfner · 2025-10-09T13:07:35Z

another topic: a user can change the color of the code minings in the "fonts and colors" preference page. If you do this you will see a mix of colors:
Maybe this can be improved:

either by ignoring the users color pref here

also use the code mining color from preferences for the other "white space character" drawing logic.

I tried to ignore and overwrite the color with the one TextEditor uses for drawing spaces, tabs,...
According to

eclipse.platform.ui/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/WhitespaceCharacterPainter.java

Line 447 in 2c5b605

fg= fTextWidget.getForeground();

this is SWT.COLOR_LIST_FOREGROUND, which is black.
I even debugged the drawing of a tab and it was colored 0, 0, 0 but appeared grey. I dont get it....

BeckerWdf · 2025-10-10T14:32:30Z

I just played around a bit with the current state.
I got this:

java.lang.NullPointerException: Cannot invoke "org.eclipse.swt.widgets.Display.getSystemColor(int)" because the return value of "org.eclipse.swt.widgets.Display.getCurrent()" is null
	at org.eclipse.ui.internal.texteditor.codemining.ZeroWidthCharactersLineContentCodeMining.<init>(ZeroWidthCharactersLineContentCodeMining.java:40)
	at org.eclipse.ui.internal.texteditor.codemining.ZeroWidthCharactersLineContentCodeMiningProvider.createCodeMining(ZeroWidthCharactersLineContentCodeMiningProvider.java:108)
	at org.eclipse.ui.internal.texteditor.codemining.ZeroWidthCharactersLineContentCodeMiningProvider.provideCodeMinings(ZeroWidthCharactersLineContentCodeMiningProvider.java:72)
	at org.eclipse.jface.internal.text.codemining.CodeMiningManager.lambda$2(CodeMiningManager.java:194)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)

BeckerWdf · 2025-10-13T05:45:34Z

fixed with the last commit.

Thanks. That looks good now.

BeckerWdf · 2025-10-13T05:46:18Z

I just played around a bit with the current state. I got this:

java.lang.NullPointerException: Cannot invoke "org.eclipse.swt.widgets.Display.getSystemColor(int)" because the return value of "org.eclipse.swt.widgets.Display.getCurrent()" is null
	at org.eclipse.ui.internal.texteditor.codemining.ZeroWidthCharactersLineContentCodeMining.<init>(ZeroWidthCharactersLineContentCodeMining.java:40)
	at org.eclipse.ui.internal.texteditor.codemining.ZeroWidthCharactersLineContentCodeMiningProvider.createCodeMining(ZeroWidthCharactersLineContentCodeMiningProvider.java:108)
	at org.eclipse.ui.internal.texteditor.codemining.ZeroWidthCharactersLineContentCodeMiningProvider.provideCodeMinings(ZeroWidthCharactersLineContentCodeMiningProvider.java:72)
	at org.eclipse.jface.internal.text.codemining.CodeMiningManager.lambda$2(CodeMiningManager.java:194)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)

This is now also fixed. Thanks,

marcushoepfner · 2025-10-13T05:55:02Z

I just played around a bit with the current state. I got this:

java.lang.NullPointerException: Cannot invoke "org.eclipse.swt.widgets.Display.getSystemColor(int)" because the return value of "org.eclipse.swt.widgets.Display.getCurrent()" is null
	at org.eclipse.ui.internal.texteditor.codemining.ZeroWidthCharactersLineContentCodeMining.<init>(ZeroWidthCharactersLineContentCodeMining.java:40)
	at org.eclipse.ui.internal.texteditor.codemining.ZeroWidthCharactersLineContentCodeMiningProvider.createCodeMining(ZeroWidthCharactersLineContentCodeMiningProvider.java:108)
	at org.eclipse.ui.internal.texteditor.codemining.ZeroWidthCharactersLineContentCodeMiningProvider.provideCodeMinings(ZeroWidthCharactersLineContentCodeMiningProvider.java:72)
	at org.eclipse.jface.internal.text.codemining.CodeMiningManager.lambda$2(CodeMiningManager.java:194)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)

This is now also fixed. Thanks,

Is the color of "ZWSP" grey or black in your case?

BeckerWdf · 2025-10-13T05:55:03Z

I tried to ignore and overwrite the color with the one TextEditor uses for drawing spaces, tabs,... According to

eclipse.platform.ui/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/WhitespaceCharacterPainter.java

Line 447 in 2c5b605

fg= fTextWidget.getForeground();

this is SWT.COLOR_LIST_FOREGROUND, which is black.
I even debugged the drawing of a tab and it was colored 0, 0, 0 but appeared grey. I dont get it....

I also just debugged this. And I see that the color (for the whitespace chars comes from the styleRange not the textWidget:

eclipse.platform.ui/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/WhitespaceCharacterPainter.java

Line 449 in 2c5b605

fg= styleRange.foreground;

BeckerWdf · 2025-10-13T05:56:12Z

Is the color of "ZWSP" grey or black in your case?

black.

tobiasmelcher · 2026-01-23T14:03:00Z

The WhitespaceCharacterPainter uses in the light theme the black color Color {0, 0, 0, 255} to draw the invisible characters with gc.drawString. It looks greyish because gc.setAlpha(fAlpha); is called beforehand with value fAlpha=80.
Here the location where setAlpha is called.

private void handleDrawRequest(GC gc, int x, int y, int w, int h) {
		int startLine= fTextWidget.getLineIndex(y);
		int endLine= fTextWidget.getLineIndex(y + h - 1);
		if (startLine <= endLine && startLine < fTextWidget.getLineCount()) {

			// avoid painting into the margins:
			Rectangle clipping= gc.getClipping();
			Rectangle clientArea= fTextWidget.getClientArea();
			int leftMargin= fTextWidget.getLeftMargin();
			int rightMargin= fTextWidget.getRightMargin();
			clientArea.x+= leftMargin;
			clientArea.width-= leftMargin + rightMargin;
			clipping.intersect(clientArea);
			gc.setClipping(clientArea);
			if (fIsAdvancedGraphicsPresent) {
				int alpha= gc.getAlpha();
				gc.setAlpha(fAlpha); // <!------------------------------------
				drawLineRange(gc, startLine, endLine, x, w);
				gc.setAlpha(alpha);
			} else {
				drawLineRange(gc, startLine, endLine, x, w);
			}
			gc.setClipping(clipping);
		}
	}

We could do the same in the ZeroWidthCharactersLineContentCodeMining so that all whitespaces are rendered in the same color. Maybe introduce a re-usable in WhitespaceCharacterPainter to retrieve the color config which can then be reused by the code mining.

tobiasmelcher · 2026-01-23T16:30:03Z

[c5d21c1] sets the same color in the ZWSP code minings as it is done in the whitespace character painter

marcushoepfner · 2026-02-12T08:47:24Z

don't merge master in your feature branch - we cannot merge these. Pls. rebase your feature branch on top of master.

argh, sorry. It's been a while... :)

BeckerWdf · 2026-02-12T09:09:06Z

Is this PR in "draft" state by intention?

marcushoepfner · 2026-02-12T09:23:40Z

Is this PR in "draft" state by intention?

It is ready-for-review now.
Draft for me means, we still working on it. And that was the case until this morning.

marcushoepfner · 2026-02-12T12:47:58Z

Interesting, the current version in main branch is 3.20

But the API warning says something about 3.19...

I "just" added a new public constant. Why is this considered a broken API? Guess going for 4.0.0 is not an option here :)

iloveeclipse · 2026-02-12T13:11:33Z

Interesting, the current version in main branch is 3.20

And that is the problem

But the API warning says something about 3.19...

Because we don't increase minor version twice for the same release. It was already bumped in 5f6cae6.

So please undo the version increment in manifest and change since tag to 3.20.
After that there will be still API error on org.eclipse.ui.texteditor.AbstractTextEditor.PREFERENCE_SHOW_ZW_CHARACTERS, and you can add a filter for this error in the editor via Ctrl+1.

Also would be good if you could squash all commits to a single one and after that rebase on latest master branch.

iloveeclipse · 2026-02-12T13:13:49Z

But honestly speaking, today is last day for API changes (tomorrow is M3), I don't expect this change qualifies for RC builds, therefore you can keep on the version bump anyway but do the rest and wait for review comments & merge in the next SDK release.

eclipse-platform-bot · 2026-03-01T12:14:30Z

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
bundles/org.eclipse.ui.workbench.texteditor/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From b53315420db0f4269cd196313fd2dfecc3638152 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sun, 1 Mar 2026 12:28:31 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
index 5a78bb6d2b..4277421c00 100644
--- a/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.editors; singleton:=true
-Bundle-Version: 3.21.0.qualifier
+Bundle-Version: 3.21.100.qualifier
 Bundle-Activator: org.eclipse.ui.internal.editors.text.EditorsPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
diff --git a/bundles/org.eclipse.ui.workbench.texteditor/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.workbench.texteditor/META-INF/MANIFEST.MF
index 7f40fef68b..b73a5fba66 100644
--- a/bundles/org.eclipse.ui.workbench.texteditor/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.workbench.texteditor/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.workbench.texteditor; singleton:=true
-Bundle-Version: 3.20.0.qualifier
+Bundle-Version: 3.20.100.qualifier
 Bundle-Activator: org.eclipse.ui.internal.texteditor.TextEditorPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

marcushoepfner · 2026-03-02T14:05:15Z

Interesting, the current version in main branch is 3.20

And that is the problem

But the API warning says something about 3.19...

Because we don't increase minor version twice for the same release. It was already bumped in 5f6cae6.

So please undo the version increment in manifest and change since tag to 3.20. After that there will be still API error on org.eclipse.ui.texteditor.AbstractTextEditor.PREFERENCE_SHOW_ZW_CHARACTERS, and you can add a filter for this error in the editor via Ctrl+1.

Also would be good if you could squash all commits to a single one and after that rebase on latest master branch.

I don't see the quickfix/error.
I used 2026-03 RC2 as baseline and did not change any settings. I can even see that org.eclipse.ui.workbench.texteditor already has one filter.

Is there any documentation on how to setup the baseline?
I followed the help, but it did not solve my problem.
Contributing.md does not contain information regarding baseline setup. I wonder why not, as this seems to be an essential step in Eclipse contribution.

marcushoepfner · 2026-03-03T06:36:18Z

Interesting, the current version in main branch is 3.20

And that is the problem

But the API warning says something about 3.19...

Because we don't increase minor version twice for the same release. It was already bumped in 5f6cae6.
So please undo the version increment in manifest and change since tag to 3.20. After that there will be still API error on org.eclipse.ui.texteditor.AbstractTextEditor.PREFERENCE_SHOW_ZW_CHARACTERS, and you can add a filter for this error in the editor via Ctrl+1.
Also would be good if you could squash all commits to a single one and after that rebase on latest master branch.

I don't see the quickfix/error. I used 2026-03 RC2 as baseline and did not change any settings. I can even see that org.eclipse.ui.workbench.texteditor already has one filter.

Is there any documentation on how to setup the baseline? I followed the help, but it did not solve my problem. Contributing.md does not contain information regarding baseline setup. I wonder why not, as this seems to be an essential step in Eclipse contribution.

@merks Can you help here?

.

Issue: eclipse-platform#1002

iloveeclipse · 2026-03-10T06:18:48Z

This change introduces memory leak, please check eclipse-jdt/eclipse.jdt.ui#2856.

BeckerWdf · 2026-03-10T07:19:27Z

@marcushoepfner: Can you pls. have a look?

mickaelistria reviewed Dec 19, 2023

View reviewed changes

...r/src/org/eclipse/ui/internal/texteditor/codemining/ZeroWidthSpaceLineContentCodeMining.java Outdated Show resolved Hide resolved

BeckerWdf reviewed Dec 20, 2023

View reviewed changes

...g/eclipse/ui/internal/texteditor/codemining/ZeroWidthSpaceLineContentCodeMiningProvider.java Outdated Show resolved Hide resolved

marcushoepfner force-pushed the zwsp branch 4 times, most recently from b082ac8 to 6cccc08 Compare August 5, 2025 14:06

marcushoepfner marked this pull request as draft August 6, 2025 06:21

marcushoepfner marked this pull request as ready for review August 13, 2025 06:35

BeckerWdf previously requested changes Aug 13, 2025

View reviewed changes

marcushoepfner force-pushed the zwsp branch from 692f1f0 to 55220bd Compare October 9, 2025 13:02

marcushoepfner force-pushed the zwsp branch 3 times, most recently from 0ee781a to 8b2948b Compare October 9, 2025 13:27

marcushoepfner marked this pull request as draft October 13, 2025 05:20

marcushoepfner force-pushed the zwsp branch from 3b02ed7 to c97d0b4 Compare October 13, 2025 05:59

tobiasmelcher force-pushed the zwsp branch from c97d0b4 to c5d21c1 Compare January 23, 2026 16:16

marcushoepfner marked this pull request as ready for review February 12, 2026 08:47

BeckerWdf self-requested a review February 12, 2026 12:28

marcushoepfner force-pushed the zwsp branch from b81cb31 to 181a6ee Compare February 16, 2026 10:45

marcushoepfner changed the title ~~Show ZWSP (zero with space) as code mining~~ Show ZWSP (zero width space) as code mining Feb 25, 2026

marcushoepfner force-pushed the zwsp branch from 181a6ee to 8059c71 Compare February 25, 2026 15:57

marcushoepfner force-pushed the zwsp branch 3 times, most recently from 187db2b to c0ba961 Compare March 2, 2026 13:37

tobiasmelcher force-pushed the zwsp branch from c0ba961 to 7bf86d5 Compare March 5, 2026 14:50

tobiasmelcher force-pushed the zwsp branch 3 times, most recently from decc6d5 to 3b32020 Compare March 5, 2026 17:24

marcushoepfner force-pushed the zwsp branch from 60af1fd to 3b32020 Compare March 9, 2026 07:10

Show ZWSP (zero with space) as code mining

a0b6352

Issue: eclipse-platform#1002

marcushoepfner force-pushed the zwsp branch from 3b32020 to a0b6352 Compare March 9, 2026 07:10

marcushoepfner merged commit b8d7d92 into eclipse-platform:master Mar 9, 2026
18 checks passed

marcushoepfner deleted the zwsp branch March 9, 2026 08:16

iloveeclipse mentioned this pull request Mar 10, 2026

16 JavaLeakTest tests failing since I20260309-1800 eclipse-jdt/eclipse.jdt.ui#2856

Open

Conversation

marcushoepfner commented Dec 19, 2023

Uh oh!

Uh oh!

github-actions bot commented Dec 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

BeckerWdf commented Dec 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

BeckerWdf commented Aug 13, 2025

Uh oh!

BeckerWdf left a comment

Choose a reason for hiding this comment

Uh oh!

BeckerWdf commented Aug 13, 2025

Uh oh!

marcushoepfner commented Oct 9, 2025

Uh oh!

marcushoepfner commented Oct 9, 2025

Uh oh!

BeckerWdf commented Oct 10, 2025

Uh oh!

BeckerWdf commented Oct 13, 2025

Uh oh!

BeckerWdf commented Oct 13, 2025

Uh oh!

marcushoepfner commented Oct 13, 2025

Uh oh!

BeckerWdf commented Oct 13, 2025

Uh oh!

BeckerWdf commented Oct 13, 2025

Uh oh!

tobiasmelcher commented Jan 23, 2026

Uh oh!

tobiasmelcher commented Jan 23, 2026

Uh oh!

marcushoepfner commented Feb 12, 2026

Uh oh!

BeckerWdf commented Feb 12, 2026

Uh oh!

marcushoepfner commented Feb 12, 2026

Uh oh!

marcushoepfner commented Feb 12, 2026

Uh oh!

iloveeclipse commented Feb 12, 2026

Uh oh!

iloveeclipse commented Feb 12, 2026

Uh oh!

eclipse-platform-bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcushoepfner commented Mar 2, 2026

Uh oh!

marcushoepfner commented Mar 3, 2026

Uh oh!

Uh oh!

iloveeclipse commented Mar 10, 2026

Uh oh!

BeckerWdf commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Dec 19, 2023 •

edited

Loading

BeckerWdf commented Dec 20, 2023 •

edited

Loading

eclipse-platform-bot commented Mar 1, 2026 •

edited

Loading