Skip to content

engine: add bind-create-src mount option#24140

Open
dvdksn wants to merge 1 commit intodocker:mainfrom
dvdksn:bind-create-src
Open

engine: add bind-create-src mount option#24140
dvdksn wants to merge 1 commit intodocker:mainfrom
dvdksn:bind-create-src

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Feb 13, 2026

Description

Adds a new option for --mount type=bind

Related issues or tickets

@netlify
Copy link

netlify bot commented Feb 13, 2026

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 489c731
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/69a97ed8f4563800089287e3
😎 Deploy Preview https://deploy-preview-24140--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dvdksn dvdksn marked this pull request as draft February 13, 2026 09:17
@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/get-started Relates to get started and onboarding docs area/storage Relates to storage, volumes labels Feb 13, 2026
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation Review Summary

Found 2 medium-severity issues in the new content documenting the bind-create-src option:

  1. Terminology inconsistency: Using "source directory" vs "source path" inconsistently
  2. Misleading example: Using /dev/mydir which suggests creating directories in a system-reserved path

Both issues are in the newly added content and should be addressed for clarity and accuracy.

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn force-pushed the bind-create-src branch from 4e672e6 to 489c731 Compare March 5, 2026 13:02
@dvdksn dvdksn marked this pull request as ready for review March 5, 2026 13:02
@dvdksn dvdksn added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Mar 5, 2026
@dvdksn dvdksn requested a review from vvoland March 5, 2026 13:02
Copy link
Contributor

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Assessment: 🟡 NEEDS ATTENTION

Found 1 issue in the new bind-create-src option documentation.

Summary

The PR successfully documents the new bind-create-src mount option, but there's one terminology inconsistency that should be corrected for clarity.

Issue:

  • MEDIUM severity: Inconsistent terminology in the option description (uses "daemon" instead of "host")

Details

The changes correctly add "By default," qualifiers to explain the new behavior option, and the command syntax examples are accurate. The table entry for the new option needs a terminology fix to maintain consistency with the rest of the document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Issue affects Docker engine/daemon area/get-started Relates to get started and onboarding docs area/storage Relates to storage, volumes status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant