Conversation
denik
requested review from
andrewnester,
anton-107,
pietern,
shreyas-goenka and
simonfaltum
as code owners
Collaborator
|
Commit: 8653aba
25 interesting tests: 8 FAIL, 7 KNOWN, 7 SKIP, 2 flaky, 1 BUG
Top 20 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/simpler-grant
branch
from
750657c to
839ba96
Compare
denik
force-pushed
the
denik/simpler-grant
branch
from
1608e31 to
d8d1d4a
Compare
Removes five custom grant types (Grant, SchemaGrant, CatalogGrant, ExternalLocationGrant, VolumeGrant) and their associated per-resource privilege enums. All resources now use catalog.PrivilegeAssignment directly from the Databricks SDK. Also removes the reflection-based conversion in PrepareGrantsInputConfig replacing it with a simple type assertion, and removes the now-unnecessary TestSchemaGrantPrivilegesExhaustive test that maintained the enum sync. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
denik
force-pushed
the
denik/simpler-grant
branch
from
d8d1d4a to
45c5cd4
Compare
…rants INSERT is not a valid Unity Catalog privilege. After switching from the custom Grant type (which used []string for privileges) to catalog.PrivilegeAssignment from the SDK, the privileges field is now enum-validated. MODIFY is the appropriate UC privilege for write operations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CatalogGrant/SchemaGrant/VolumeGrant and their privilege enums were replaced by the unified PrivilegeAssignment/Privilege types. Add aliases in each namespace's __init__.py so existing code continues to work without changes. The generator now reads codegen/aliases_patch.py and emits OldName = NewName assignments into each namespace's __init__.py, including the old names in __all__. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Validates that old per-resource grant aliases (SchemaGrant, SchemaGrantPrivilege) and new unified types (PrivilegeAssignment, Privilege) both work in bundle validate, producing identical output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andrewnester
approved these changes
Mar 6, 2026
| "resources.apps.*.resources[*].uc_securable": {"permission", "securable_full_name", "securable_type"}, | ||
|
|
||
| "resources.catalogs.*": {"name"}, | ||
| "resources.catalogs.*.grants[*]": {"privileges", "principal"}, |
Contributor
There was a problem hiding this comment.
Is it expected that now these fields are not required?
Contributor
Author
There was a problem hiding this comment.
yes, omitempty annotation is different between SDK and our own types.
lennartkats-db
approved these changes
Mar 6, 2026
pietern
approved these changes
Mar 6, 2026
Contributor
Author
|
Alert integration tests timed out, does not seem related. |
Collaborator
|
Commit: c779b91
45 interesting tests: 16 RECOVERED, 12 FAIL, 8 flaky, 7 KNOWN, 1 BUG, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
shreyas-goenka
added a commit
that referenced
this pull request
Mar 6, 2026
After rebase on main, adapt to #4666 which switched grants from custom per-resource types to SDK catalog.PrivilegeAssignment. Remove stale per-resource grant annotation entries (descriptions now come from OpenAPI), regenerate schema and python codegen, and clean up .wsignore references to deleted docsgen files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Maintaining custom types is manual process. This prevents us from moving to autogenerated resources. This also causes issues for users where definition in CLI lags behind. #3821 #4008