Strip trailing slash from host in auth and configure commands

[varundeepsaini]

Fixes #4628

Summary

• Strip trailing slash from host URL in setHostAndAccountId (used by auth login and auth token)
• Strip trailing slash in normalizeHost (used by databricks configure)

Test plan

• Added test cases for trailing slash stripping in setHostAndAccountId (flag and positional arg)
• Updated normalizeHost test expectations for trailing slash inputs
• Verified all existing tests pass

[simonfaltum]

LGTM

Just taking another look

[simonfaltum]

Had an extra look. Would you be up for adding some tests for the auth token path?
The setHostAndAccountId function is also called from cmd/auth/token.go:166 and token.go:426

[simonfaltum]

Using strings.TrimRight(input, "/"), which strips all trailing / characters from the right side of the string, character by character. I think this is subtly wrong for edge cases.

Look at the test expectation on line 32 of host_test.go: {"https://", "https:"},

TrimRight("https://", "/") strips both trailing slashes from https://, producing "https:". That's clearly broken. The input https:// is an invalid host either way, but the function is now actively mangling it in a confusing way. I think the correct function to use is strings.TrimSuffix(input, "/") which only removes a single trailing /.

For https://example.com/ both functions produce the same result, but TrimRight is a future trap for multi-slash paths or edge cases, I think?

[simonfaltum]

Thanks Varun! LGTM

[varundeepsaini]

@simonfaltum could you run the ci ?

[github-actions]

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

• PR number: 4633
• Commit SHA: 5149e4611294a209290a64bdd3fbf9fa1cb92796

Checks will be approved automatically on success.