Open
Conversation
Introduce full config entry support and UI options for the Feedparser integration. Adds config_flow, options flow, constants, translations/strings, and migration logic (ENTRY_VERSION bump) with normalization helpers for inclusions/exclusions and scan_interval. Refactors sensor to support async_setup_entry, unique_id, configurable scan_interval, safer typing/casting, improved image/link/date handling, and keeps legacy YAML platform support. Updates manifest (config_flow:true, version bump), README with UI setup and configuration reference, adds devcontainer and helper scripts for development, and includes minor test and test-data cleanups.
Import Home Assistant config validation and add CONFIG_SCHEMA = cv.platform_only_config_schema(DOMAIN) to declare platform-only YAML configuration and enable proper config validation. Also import DOMAIN from consts and tidy manifest.json key ordering (move config_flow, domain, name) for consistency; no functional logic changes.
Closed
…andling for improved clarity and functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major refactor and modernization of the Feedparser custom component for Home Assistant. The integration now supports a full config flow for UI-based setup and options management, improves documentation for both UI and YAML configuration paths, and standardizes option handling and migration. The codebase is restructured for clarity and maintainability, and a development container is added for easier local development.
Core integration and configuration improvements:
custom_components/feedparser/config_flow.py) for UI-based setup and options, including validation, migration, and options flow support. This enables users to add and configure Feedparser entirely through the Home Assistant UI.custom_components/feedparser/__init__.py) to support config entry setup, unloading, migration, and option normalization for both UI and YAML paths.custom_components/feedparser/const.py) to centralize all option keys, defaults, and platform definitions, improving maintainability and consistency.Documentation and user guidance:
README.mdto clearly explain both UI and YAML configuration methods, provide detailed option references, clarify field behaviors, and add a section for development container usage.Development and packaging:
.devcontainer.jsonfor VS Code development container support, streamlining local development and testing of the integration.manifest.jsonto enable config flow support, bump the version to1.0.0, and format requirements and codeowners for clarity.