Skip to content

feat: support clang version to include 22 and adjust default version to 20#398

Merged
shenxianpeng merged 2 commits intomainfrom
feature/support-v22
Mar 4, 2026
Merged

feat: support clang version to include 22 and adjust default version to 20#398
shenxianpeng merged 2 commits intomainfrom
feature/support-v22

Conversation

@shenxianpeng
Copy link
Collaborator

@shenxianpeng shenxianpeng commented Mar 3, 2026

closes #397

Summary by CodeRabbit

  • Chores
    • Updated supported clang versions to 11–22 (removed 9 and 10; added 22).
    • Changed default clang version from 18 to 20.
    • Updated action input options to reflect the new version list.
    • Bumped tooling versions for clang tools and C++ linter.

@shenxianpeng shenxianpeng requested a review from a team as a code owner March 3, 2026 19:53
@shenxianpeng shenxianpeng requested review from 2bndy5 and removed request for a team March 3, 2026 19:53
@shenxianpeng shenxianpeng marked this pull request as draft March 3, 2026 19:54
@shenxianpeng shenxianpeng added the enhancement New feature or request label Mar 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v16.0.6) reports: 2 file(s) not formatted
  • docs/examples/demo/demo.hpp
  • docs/examples/demo/demo.cpp
clang-tidy (v16.0.6) reports: 7 concern(s)

Have any feedback or feature suggestions? Share it here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7d07ea18-8bea-494a-89e3-e5f9ed72fb50

📥 Commits

Reviewing files that changed from the base of the PR and between d79f814 and bb8ad71.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • .github/workflows/self-test.yml
  • action.yml
  • pyproject.toml
🚧 Files skipped from review as they are similar to previous changes (2)
  • action.yml
  • pyproject.toml

Walkthrough

Updated CI and action configuration to add clang/clang-format 22, remove clang versions 9 and 10, change the action default version from 18 to 20, and bumped two action-related dependency package versions in pyproject.toml.

Changes

Cohort / File(s) Summary
CI workflow
.github/workflows/self-test.yml
Removed clang versions 9, 10 from the matrix and added 22 to the clang-version list.
GitHub Action metadata
action.yml
Updated version input description to include 22 (removed 10, 9) and changed default from 18 to 20.
Action dependencies
pyproject.toml
Bumped clang-tools 0.16.00.17.0 and cpp-linter 1.11.41.12.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • 2bndy5
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: adding clang version 22 support and adjusting the default version to 20.
Linked Issues check ✅ Passed The PR successfully addresses issue #397 by adding clang version 22 to supported versions in self-test.yml and action.yml, and updates dependencies accordingly.
Out of Scope Changes check ✅ Passed All changes directly support the objectives: version 22 support and default version adjustment. The dependency bumps for clang-tools and cpp-linter are necessary for proper v22 support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/support-v22

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@shenxianpeng shenxianpeng changed the title feat: update clang version support to include 22 and adjust default version to 20 feat: support clang version to include 22 and adjust default version to 20 Mar 3, 2026
@2bndy5
Copy link
Collaborator

2bndy5 commented Mar 4, 2026

Windows runner failed (as I suspected) because v22 is not available on runner by default and we don't have a static binary built for v22.

MacOS runner succeeded because there is a homebrew formula for v22.

Linux runner failed. This is a little confusing. It looks like the LLVM PPA does not have any v22 builds uploaded (yet). Also, like Windows runner, we don't have any v22 static binary builds to use as a fall back.

We should really test out #368 because there are v22 builds available on PyPI.

@shenxianpeng
Copy link
Collaborator Author

Windows runner failed (as I suspected) because v22 is not available on runner by default and we don't have a static binary built for v22.

After bump clang-tools version to v0.17.0, this failure will be removed. this version will support v22 binaries on Window, Linux and macOS (arm and Intel)

@shenxianpeng
Copy link
Collaborator Author

once #401 is merged and we rebase for this PR, I assume CI should be pass.

@shenxianpeng
Copy link
Collaborator Author

We should really test out #368 because there are v22 builds available on PyPI.

clang-tidy v22 wheel not published now, we could consider switch after ssciwr/clang-tidy-wheel#114 is done.

@shenxianpeng shenxianpeng marked this pull request as ready for review March 4, 2026 18:57
@shenxianpeng shenxianpeng added the minor A minor version bump label Mar 4, 2026
shenxianpeng and others added 2 commits March 4, 2026 22:19
Bumps the org group with 2 updates: [clang-tools](https://github.com/cpp-linter/clang-tools-pip) and [cpp-linter](https://github.com/cpp-linter/cpp-linter).


Updates `clang-tools` from 0.16.0 to 0.17.0
- [Release notes](https://github.com/cpp-linter/clang-tools-pip/releases)
- [Commits](cpp-linter/clang-tools-pip@v0.16.0...v0.17.0)

Updates `cpp-linter` from 1.11.4 to 1.12.0
- [Release notes](https://github.com/cpp-linter/cpp-linter/releases)
- [Commits](cpp-linter/cpp-linter@v1.11.4...v1.12.0)

---
updated-dependencies:
- dependency-name: clang-tools
  dependency-version: 0.17.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: org
- dependency-name: cpp-linter
  dependency-version: 1.12.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: org
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@shenxianpeng shenxianpeng force-pushed the feature/support-v22 branch from d79f814 to bb8ad71 Compare March 4, 2026 20:19
@shenxianpeng shenxianpeng merged commit 2446798 into main Mar 4, 2026
45 checks passed
@shenxianpeng shenxianpeng deleted the feature/support-v22 branch March 4, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor A minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can we add clang-format 22 to the list?

2 participants