feat: support clang version to include 22 and adjust default version to 20#398
feat: support clang version to include 22 and adjust default version to 20#398shenxianpeng merged 2 commits intomainfrom
Conversation
Cpp-Linter Report
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughUpdated CI and action configuration to add clang/clang-format 22, remove clang versions 9 and 10, change the action default version from 18 to 20, and bumped two action-related dependency package versions in pyproject.toml. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Windows runner failed (as I suspected) because v22 is not available on runner by default and we don't have a static binary built for v22. MacOS runner succeeded because there is a homebrew formula for v22. Linux runner failed. This is a little confusing. It looks like the LLVM PPA does not have any v22 builds uploaded (yet). Also, like Windows runner, we don't have any v22 static binary builds to use as a fall back. We should really test out #368 because there are v22 builds available on PyPI. |
After bump clang-tools version to v0.17.0, this failure will be removed. this version will support v22 binaries on Window, Linux and macOS (arm and Intel) |
|
once #401 is merged and we rebase for this PR, I assume CI should be pass. |
clang-tidy v22 wheel not published now, we could consider switch after ssciwr/clang-tidy-wheel#114 is done. |
Bumps the org group with 2 updates: [clang-tools](https://github.com/cpp-linter/clang-tools-pip) and [cpp-linter](https://github.com/cpp-linter/cpp-linter). Updates `clang-tools` from 0.16.0 to 0.17.0 - [Release notes](https://github.com/cpp-linter/clang-tools-pip/releases) - [Commits](cpp-linter/clang-tools-pip@v0.16.0...v0.17.0) Updates `cpp-linter` from 1.11.4 to 1.12.0 - [Release notes](https://github.com/cpp-linter/cpp-linter/releases) - [Commits](cpp-linter/cpp-linter@v1.11.4...v1.12.0) --- updated-dependencies: - dependency-name: clang-tools dependency-version: 0.17.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: org - dependency-name: cpp-linter dependency-version: 1.12.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: org ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
d79f814 to
bb8ad71
Compare
closes #397
Summary by CodeRabbit