test: add missing tests for get_filenames_in_commit with git_reference#1883
Conversation
Add test coverage for get_filenames_in_commit() when called with an explicit git_reference parameter. Previously only the error case and the integration test (no git_reference) existed. New tests: - test_get_filenames_in_commit: success case without git_reference - test_get_filenames_in_commit_with_git_reference: success case with explicit reference, verifying the correct git command is called - test_get_filenames_in_commit_error_with_git_reference: error case with explicit reference Closes commitizen-tools#1860 Signed-off-by: edvatar <88481784+toroleapinc@users.noreply.github.com>
toroleapinc
requested review from
Lee-W,
noirbizarre and
woile
as code owners
|
|
Please answer the questions in PR description template and please fix the pipeline failure |
bearomorphism
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
|
And we already assigned #1860 to another contributor. You should comment on the issue and ask if you can take the issue first. |
|
@bearomorphism Thanks for the feedback! You're absolutely right - I should have checked the assignment status first and followed proper protocol. I apologize for jumping ahead on issue #1860 without coordinating. I'll close this PR and comment on the issue to check if the assigned contributor needs any help or if they're still working on it. I'll also make sure to follow the PR template properly if I submit any future contributions. Thanks for the guidance on the process! |
|
Closing as LLM generated PR |
2 participants
Summary
Add test coverage for
get_filenames_in_commit()when called with an explicitgit_referenceparameter. Previously only the error case (no reference) and an integration test existed.New tests
test_get_filenames_in_commit: success case without git_referencetest_get_filenames_in_commit_with_git_reference: success case with explicit reference, verifying the correct git command is constructedtest_get_filenames_in_commit_error_with_git_reference: error case with explicit referenceCloses #1860