fix(ci): remove archive: false from release workflows#822
Open
Conversation
EhabY
force-pushed
the
fix/ci-release-archive
branch
from
fa4fb34 to
f98cc1d
Compare
With `archive: false`, the `name` parameter is ignored and the artifact name becomes the uploaded filename. This broke the publish workflow which downloads artifacts by name.
EhabY
force-pushed
the
fix/ci-release-archive
branch
from
f98cc1d to
aff58e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
archive: false, thenameparameter is ignored and the artifact name becomes the uploaded filenamearchive: falsefrom release/pre-release workflows and removes the redundantnamefrom CI uploads