Move example project and build scripts to Java 17; add compatibility helpers and Java version parsing#4595
Closed
shai-almog wants to merge 2 commits intomasterfrom
Closed
Conversation
…bjxela Signed-off-by: Shai Almog <67850168+shai-almog@users.noreply.github.com>
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
Author
Android screenshot updatesCompared 32 screenshots: 31 matched, 1 updated.
Native Android coverage
|
✅ ByteCodeTranslator Quality ReportTest & Coverage
Benchmark Results
Static Analysis
Generated automatically by the PR CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Description
pom.xml.mvnw,mvnw.cmd,build.sh,run.sh,build.bat,run.bat,mvnwwrappers) and setJAVA_HOMEfor maven invocations inscripts/build-ios-app.sh.Java17LanguageFeaturesTestto the example common tests to validate new language features compile in tests.parseJavaVersion(String,int)helper and replaced fragile integer parsing inCN1BuildMojoandInstallCn1libsMojoto properly normalize and compare Java versions.DEFAULT_DONTWARN_CLASSESand emit-dontwarnentries inComplianceCheckMojoto suppress known non-actionable warnings (e.g.java.rmi.Remote,java.util.Arrays$ArrayList).StringConcatFactory.javastubs inPorts/CLDC11andvm/JavaAPIto provide minimal compatibility for invokedynamic-based string concat during builds.Testing
Java17LanguageFeaturesTestvia Maven and the test passed.mvn package(wrapper) to verify compiler/toolchain changes and the build completed successfully.JAVA_HOMEoverride behavior exercised and OK).Codex Task