Update Definitions to Include Signature by raphael-goetz · Pull Request #262 · code0-tech/code0-definition

raphael-goetz · 2026-03-04T12:18:28Z

Resolves: #256

…fier

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 146 out of 148 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/cli/src/analyser/flow_type.rs

definitions/standard/runtime_definition/control/std_control_stop.proto.json

definitions/standard/runtime_definition/number/std_number_ln.proto.json

definitions/standard/runtime_definition/array/std_array_is_empty.proto.json

definitions/standard/data_type/node/comparator.proto.json

definitions/standard/runtime_definition/object/std_object_keys.proto.json

definitions/standard/runtime_definition/number/std_number_from_text.proto.json

definitions/standard/runtime_definition/boolean/std_boolean_from_text.proto.json

definitions/standard/runtime_definition/array/std_array_reverse.proto.json

crates/cli/src/analyser/flow_type.rs

Copilot

Pull request overview

Copilot reviewed 146 out of 148 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/cli/src/diagnostics/diagnose.rs

crates/cli/src/analyser/flow_type.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>

nicosammito · 2026-03-04T21:20:11Z

definitions/cron/data_type/type/cron_day_of_month.proto.json

  ],
-  "genericKeys": []
+  "linked_data_type_identifiers": [],
+  "signature": "string"


Is it really a string? You can parse in 0-11 and also the short term right? So JAN, FEB?

nicosammito · 2026-03-04T21:20:20Z

definitions/cron/data_type/type/cron_day_of_week.proto.json

  ],
-  "genericKeys": []
+  "linked_data_type_identifiers": [],
+  "signature": "string"


nicosammito · 2026-03-04T21:20:27Z

definitions/cron/data_type/type/cron_hour.proto.json

  ],
-  "genericKeys": []
+  "linked_data_type_identifiers": [],
+  "signature": "string"


nicosammito · 2026-03-04T21:20:32Z

definitions/cron/data_type/type/cron_minute.proto.json

  ],
-  "genericKeys": []
+  "linked_data_type_identifiers": [],
+  "signature": "string"


nicosammito · 2026-03-04T21:20:40Z

definitions/cron/data_type/type/cron_month.proto.json

  ],
-  "genericKeys": []
+  "linked_data_type_identifiers": [],
+  "signature": "string"


definitions/standard/runtime_definition/array/std_array_index_of.proto.json

definitions/standard/runtime_definition/number/std_number_clamp.proto.json

nicosammito · 2026-03-04T22:00:48Z

definitions/standard/runtime_definition/object/std_object_set.proto.json

+  ],
+  "deprecationMessage": [],
+  "displayIcon": "tabler:cube",
+  "signature": "<T, K extends keyof OBJECT<T>>(object: OBJECT<T>, key: keyof OBJECT<T>, value: T[K]) => OBJECT<T>",


This doesn't make any sense for me, because with this logic you can only update existing fields and the value must be of the same type

nicosammito · 2026-03-04T22:06:00Z

definitions/standard/runtime_definition/boolean/std_boolean_negate.proto.json

+  ],
+  "deprecationMessage": [],
+  "displayIcon": "tabler:toggle-left",
+  "signature": "(value: BOOLEAN) => BOOLEAN",


I'm not quite sure but we could poetically increase context here:

Suggested change

"signature": "(value: BOOLEAN) => BOOLEAN",

"signature": "(value: BOOLEAN) => !BOOLEAN",

But I will need to testify this

definitions/standard/runtime_definition/object/std_object_get.proto.json

raphael-goetz added 16 commits March 4, 2026 13:12

dependencies: updated tucana to 0.0.55

dfb1968

feat: updated data types

a10fbe4

feat: updated functions to include new type instead of dataTypeIdenti…

df92ea2

…fier

feat: updated functions to include type instead of data type identifier

3a75b88

feat: updated object functions

71614f6

drop: removed data type

c8f38b6

fix: correct signature for OBJECT

aa8d99e

drop: removed regex rule from string

03296f3

feat: updated text functions

9a87b64

dependencies: update to tucana 0.0.56

1841d19

feat: removed unneeded error types

a0624ff

feat: adjusted cli to latest data type defintions

3ed5ee6

drop: removed unused code

f505d7b

ref: renamed and removed some fields

bc87968

feat: reworked definitions

4e833b1

fix: removed outdated filelds and renamed some wrong fields

8eb0b7c

raphael-goetz requested review from Taucher2003, Copilot and nicosammito March 4, 2026 12:18

Copilot started reviewing on behalf of raphael-goetz March 4, 2026 12:18 View session

fix: removed every leftover field: genericKeys

16b8d0a

Copilot AI reviewed Mar 4, 2026

View reviewed changes

raphael-goetz requested a review from Copilot March 4, 2026 13:30

Copilot started reviewing on behalf of raphael-goetz March 4, 2026 13:30 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

feat: requested changes from copilot

aad47a8

raphael-goetz requested a review from Copilot March 4, 2026 13:50

Copilot started reviewing on behalf of raphael-goetz March 4, 2026 13:50 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

crates/cli/src/diagnostics/diagnose.rs Outdated Show resolved Hide resolved

crates/cli/src/analyser/flow_type.rs Show resolved Hide resolved

Update crates/cli/src/diagnostics/diagnose.rs

8fce220

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>

raphael-goetz marked this pull request as ready for review March 4, 2026 13:56

fix: added back genericKeys for data types

85588e1

nicosammito requested changes Mar 4, 2026

View reviewed changes

raphael-goetz added 2 commits March 5, 2026 09:57

fix: correct generics in signature

6d63fcf

drop: removed defaultValue field

745349b

raphael-goetz force-pushed the 256-update-definitions branch from 9535701 to 745349b Compare March 5, 2026 08:58

	"signature": "(value: BOOLEAN) => BOOLEAN",
	"signature": "(value: BOOLEAN) => !BOOLEAN",

Conversation

raphael-goetz commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

nicosammito Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

nicosammito Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

nicosammito Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

nicosammito Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

nicosammito Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nicosammito Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

nicosammito Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants