Fix ssh-config short-lived-cert for subpath-ed hostnames#930
Open
jeslinmx wants to merge 1 commit intocloudflare:masterfrom
Open
Fix ssh-config short-lived-cert for subpath-ed hostnames#930jeslinmx wants to merge 1 commit intocloudflare:masterfrom
jeslinmx wants to merge 1 commit intocloudflare:masterfrom
Conversation
Contributor
|
Is this subject to a race condition when configuring a host name like "*.mycompany.com"? I think connecting to two hosts at the same time with this patch could cause the wrong cert to be used. |
Author
|
Sorry, but I don't think I understand the potential problem you're describing. Could you give an example of 2 hostnames that might create such a clash? |
Contributor
|
Sure, In this case I have configured access like so: After this change the config would be: Which may cause problems when SSHing to multiple hosts that match that pattern and use different SSH CA public keys at the same time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #923