fix: correct isinstance check to include bytearray in kafka conversion#265
Closed
archy-rock3t-cloud wants to merge 1 commit intocloudevents:mainfrom
Closed
fix: correct isinstance check to include bytearray in kafka conversion#265archy-rock3t-cloud wants to merge 1 commit intocloudevents:mainfrom
archy-rock3t-cloud wants to merge 1 commit intocloudevents:mainfrom
Conversation
Signed-off-by: Artem Muterko <artem@sopho.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_structured()in kafka/conversion.py hasisinstance(data, (bytes, bytes, memoryview))where
bytesis listed twice. The secondbytesshould bebytearray, matchingthe pattern used elsewhere in the codebase (e.g.,
event/base.pyline 215).Without this fix,
bytearraydata in structured Kafka CloudEvents is notbase64-encoded as expected by the spec.