Bring typescript benchmark client to parity with rust#4494
Merged
clockwork-labs-bot merged 1 commit intomasterfrom Mar 4, 2026
Merged
Bring typescript benchmark client to parity with rust#4494clockwork-labs-bot merged 1 commit intomasterfrom
clockwork-labs-bot merged 1 commit intomasterfrom
Conversation
4e62e12 to
2e927ce
Compare
Contributor
|
The code here looks good; I just need to run the benchmarks myself before approving. |
Contributor
Unfortunately, I cannot confirm this on PhoenixNAP: With this PR:All numbers are rounded (ceil) to the nearest whole thousand TPS. Typescript module
Rust module
Without this PRTypescript module
Rust module
|
Contributor
|
(The variance is also clearly higher with a typescript client.) |
Centril
approved these changes
Mar 3, 2026
Contributor
Centril
left a comment
There was a problem hiding this comment.
We decided at a meeting that the numbers were OK but that we would keep around the rust client also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
MAX_INFLIGHT_PER_WORKERfor spacetime and convexThis gives improved parity with the rust client on my machine.
Expected complexity level and risk
1
Testing