Adds code signing to tagged windows builds#4473
Merged
Conversation
bfops
reviewed
Mar 3, 2026
bfops
reviewed
Mar 3, 2026
bfops
reviewed
Mar 3, 2026
Collaborator
bfops
left a comment
There was a problem hiding this comment.
This looks pretty good to me.
I personally lean towards merging the two jobs and adding more ifs, just to minimize copy-pasta and the risk that we don't update something going forward. I think it's fine the way it is.
bfops
reviewed
Mar 3, 2026
bfops
approved these changes
Mar 3, 2026
Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Signed-off-by: Ryan <r.ekhoff@clockworklabs.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This change requires the addition of new entries in the secrets to work properly. These should be added prior to this merging.
Description of Changes
spacetimedb-update.exe,spacetimedb-cli.exe, andspacetimedb-standalone.exebefore packaging, then upload the signed artifacts as usual.Alternatives Considered
Inline signing in the existing Windows packaging step. This was rejected because it would require all Windows builds (including non-tag builds) to run on the signing-capable runner or to install/signing tooling on GitHub-hosted runners. The chosen approach isolates signing to tag releases, avoids exposing credentials in standard builds, and keeps routine CI behavior unchanged.
API and ABI breaking changes
None
Expected complexity level and risk
2 – low risk. CI-only change that adds a new signing job and preserves existing artifact layout.
Testing