Skip to content

Adds code signing to tagged windows builds#4473

Merged
rekhoff merged 2 commits intomasterfrom
rekhoff/windows-code-signing
Mar 4, 2026
Merged

Adds code signing to tagged windows builds#4473
rekhoff merged 2 commits intomasterfrom
rekhoff/windows-code-signing

Conversation

@rekhoff
Copy link
Contributor

@rekhoff rekhoff commented Feb 26, 2026

Note: This change requires the addition of new entries in the secrets to work properly. These should be added prior to this merging.

Description of Changes

  • Add a tag-only Windows signing job that runs on a self-hosted signing runner.
    • This is an alternative/separate code-path just for the signing job. See Alternatives Considered for details.
  • Skip the unsigned Windows matrix build on tags so signed artifacts are the only Windows release outputs.
  • Sign spacetimedb-update.exe, spacetimedb-cli.exe, and spacetimedb-standalone.exe before packaging, then upload the signed artifacts as usual.

Alternatives Considered

Inline signing in the existing Windows packaging step. This was rejected because it would require all Windows builds (including non-tag builds) to run on the signing-capable runner or to install/signing tooling on GitHub-hosted runners. The chosen approach isolates signing to tag releases, avoids exposing credentials in standard builds, and keeps routine CI behavior unchanged.

API and ABI breaking changes

None

Expected complexity level and risk

2 – low risk. CI-only change that adds a new signing job and preserves existing artifact layout.

Testing

  • None (Not running, workflow change only)

@rekhoff rekhoff self-assigned this Feb 26, 2026
@rekhoff rekhoff marked this pull request as ready for review February 26, 2026 01:35
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me.

I personally lean towards merging the two jobs and adding more ifs, just to minimize copy-pasta and the risk that we don't update something going forward. I think it's fine the way it is.

Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
Signed-off-by: Ryan <r.ekhoff@clockworklabs.io>
@rekhoff rekhoff added this pull request to the merge queue Mar 3, 2026
Merged via the queue into master with commit 9a1ea26 Mar 4, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants