feat(chart): show real endpoints in Helm post-install notes#2801
Open
ghophp wants to merge 1 commit intochainloop-dev:mainfrom
Open
feat(chart): show real endpoints in Helm post-install notes#2801ghophp wants to merge 1 commit intochainloop-dev:mainfrom
ghophp wants to merge 1 commit intochainloop-dev:mainfrom
Conversation
migmartri
requested changes
Mar 3, 2026
Member
migmartri
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Just added a commment re: reusability of existing codebase. We might have external_urls for both controlplane and cas apis that are configuration aware already and just need to be used.
Contributor
|
Hi, thanks for the contribution, i would create a new PR with implementation of unit tests as they are not covered right now (and are a big thing) and keep only |
Replace hardcoded placeholder endpoints in NOTES.txt with dynamic detection of actual service configuration. Add reusable gRPC endpoint helper templates (controlplane.external_grpc_url, cas.external_grpc_url) to _helpers.tpl following the same pattern as the existing HTTP helpers. NOTES.txt now provides tailored connection instructions based on the deployment type (Ingress, LoadBalancer, NodePort, ClusterIP). Closes chainloop-dev#97 Signed-off-by: ghophp <ghophp@users.noreply.github.com> Signed-off-by: Guilherme Oliveira <ghophp@gmail.com>
1fe5414 to
ff6cb78
Compare
Contributor
Author
|
Hey @migmartri @Filip7656, thanks for the feedback! I've addressed both points:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97
Summary
The Helm chart NOTES.txt previously showed hardcoded placeholder endpoints (
my-controlplane.acme.com:80). It now detects the actual service configuration (Ingress, LoadBalancer, NodePort, or ClusterIP) for both the Control Plane and Artifact CAS gRPC services and shows actionable connection instructions.chainloop config savecommand is shown with real hostnameskubectlcommands to discover the external IP/port are providedkubectl port-forwardinstructions are shown--insecureflag is only included when at least one endpoint lacks TLSExample output
Default (ClusterIP):
Ingress with TLS:
Helm unit tests
Added snapshot tests using helm-unittest with
matchSnapshotRawcovering all 6 service type combinations (ClusterIP, Ingress, Ingress+TLS, LoadBalancer, NodePort, mixed). The tests are opt-in for now and not part of the CI pipeline. To run them locally:Team: worth discussing whether we want to add
helm unittestto the CI pipeline andhelm plugin installtomake initso these run automatically going forward.