Draft
Conversation
A Task within Konflux modifies the Dockerfile being built. This process is buggy and it cannot handle the args-style RUN format. See: <konflux-ci/build-definitions#1200> Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
Derived and very similar to the OSBS builder, a back-end to support generating and syncing container sources with a Git designed to be used in conjunction with Konflux. Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
use cekit/tools/git instead. Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
This overrides the bits we need from tools/git. Now we can prepare (but not yet push) a suitable commit for Konflux. Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
Assuming the contents of the file is (mostly) defined at the image descriptor key "konflux"."rpms.in.yaml", collate, unique and sort all the packages installed for the container (across all modules); add it to the 'packages' key and write the result to target/image/rpms.in.yaml Currnetly: no schema validation for presence of "rpms.in.yaml" key (current schema is too relaxed, accepts anything); we overwrite any existing packages key, might be nicer to merge. Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very useful for me, but I don't know how many other users we might have.
This implements a konflux builder, very similar to the existing osbs builder. It is used to sync the generation results from cekit with another git repository. Unlike the osbs builder, It does not trigger a build, only prepares the sources.
There's a fair bit of clean up needed. Future feature: gather all packages to be installed and generate/update a
rpms.in.yamlfor hermetic builds. Possibly also generatingrpms.lock.yaml.