fix: preserve polyfill module ids in production#1357
Merged
Conversation
Add RuntimeGlobals.moduleFactories and RuntimeGlobals.require to native entry runtime requirements so optimized startup does not inline polyfill entries without module ids. Add production-mode integration coverage that reproduces the broken inlined startup shape and verifies polyfills runtime __webpack_require__ ids match the actual polyfill module ids for webpack and rspack.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: dcbd235 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jbroma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1356
NativeEntryPluginforRuntimeGlobals.moduleFactoriesandRuntimeGlobals.requireso polyfills runtime always references module-id-addressable factories in optimized production outputNativeEntryPluginthat runs with active optimizations (moduleIds: 'deterministic',output.iife: true)__webpack_modules__[id]()__webpack_require__(id)calls emitted by the polyfills runtime module match the actual module ids ofpolyfill1andpolyfill2NativeEntryPlugintestsTest plan
pnpm --filter integration-test test -- src/plugins/NativeEntryPlugin.test.ts