Open
Conversation
ljharb
reviewed
Jun 25, 2025
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
I think you may need to use the build config for the node tests since there's a build process, because babel doesn't work far back enough.
BoomchainLabs
approved these changes
Jun 26, 2025
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Member
Author
|
It seemed like the It's not great to rely on a dep coincidentally not being able to install, so I'll change it to not do that sometime today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ljharb's configs to test a wide range of node.js versions.
This module is probably in need of updates. A big reason for the module to exist is to target Node.js 0.8+. This setup will give some confidence going forward that all targets are actually supported.