chore(chain): deprecate CanonicalIter, and ChainOracle trait#2140
Open
oleonardolima wants to merge 1 commit intobitcoindevkit:release/chain-0.23.xfrom
Open
Conversation
- add the deprecation warning for both `CanonicalIter` and `ChainOracle` trait, as they're planned to be removed in the future. - add `#[allow(deprecated)] throughout the code to prevent related warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As both
CanonicalIterandChainOracletrait are being removed/replaced in #2038, and they're public types, we should deprecated them in a0.23.xrelease in case any user does use them directly.Notes to the reviewers
It's simply deprecating
CanonicalIterandChainOracletrait.Changelog notice
Checklists
All Submissions: