Allow single_access_token via HTTP headers#784
Open
sevgibson wants to merge 13 commits intobinarylogic:masterfrom
Open
Allow single_access_token via HTTP headers#784sevgibson wants to merge 13 commits intobinarylogic:masterfrom
sevgibson wants to merge 13 commits intobinarylogic:masterfrom
Conversation
Co-authored-by: Jared Beck <jared@jaredbeck.com>
Co-authored-by: Tieg Zaharia <tieg.zaharia@gmail.com>
Co-authored-by: Tieg Zaharia <tieg.zaharia@gmail.com>
Co-authored-by: Jared Beck <jared@jaredbeck.com>
Co-authored-by: Jared Beck <jared@jaredbeck.com>
- Access controller.request.headers instead of controller.headers, which returns response headers - Transform headers_key to CGI-compliant format (HTTP_ prefix, uppercased, hyphens to underscores) to match Rack convention - Move headers hash from MockController to MockRequest - Remove unnecessary headers delegate from AbstractAdapter Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
single_access_tokento be supplied via HTTP request headers in addition to query paramsheaders_key(e.g.headers_key "user_credentials")HTTP_prefix, uppercased, hyphens to underscores) to match Rack conventionsThis is a continuation of #728, rebased onto current master with all prior review feedback from @jaredbeck and @tiegz addressed, including:
single_access_token_enabled?andpersist_by_single_access_tokenmethodssingle_access_token_test.rbheaders_keytonil(disabled by default)controller.request.headers(request headers) instead ofcontroller.headers(response headers)Test plan
headers_keyis not set🤖 Generated with Claude Code