Skip to content

Fix Integrations tab not reflecting active route #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Fix Integrations tab not reflecting active route #2901

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d0ca37
Initial plan
Copilot Mar 5, 2026
3a6d87c
Fix Integrations tab selection not matching nested routes
Copilot Mar 5, 2026
010f2f8
Fix tab reactivity by passing page.url.pathname directly in template
Copilot Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/routes/(console)/project-[region]-[project]/overview/+layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@
return usage.load(dates.start, dates.end, dates.period);
}

function isTabSelected(key: string) {
return page.url.pathname.endsWith(`/${key}`);
function isTabSelected(key: string, pathname: string) {
return pathname.split('/').includes(key);
}

$: $registerCommands([
Expand Down Expand Up @@ -227,17 +227,17 @@
noscroll
event="platforms"
href={`${path}/platforms`}
selected={isTabSelected('platforms')}>Platforms</Tab>
selected={isTabSelected('platforms', page.url.pathname)}>Platforms</Tab>
Copy link
Contributor

@stnguyen90 stnguyen90 Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reactivity issue was the problem. is there a cleaner approach?

<Tab
noscroll
event="api-keys"
href={`${path}/api-keys`}
selected={isTabSelected('api-keys')}>API keys</Tab>
selected={isTabSelected('api-keys', page.url.pathname)}>API keys</Tab>
<Tab
noscroll
event="dev-keys"
href={`${path}/dev-keys`}
selected={isTabSelected('dev-keys')}>Dev keys</Tab>
selected={isTabSelected('dev-keys', page.url.pathname)}>Dev keys</Tab>
</Tabs>
{#if $action}
<svelte:component this={$action} />
Expand Down
Loading