Skip to content

Create AddStatusWarning helper#756

Merged
kabicin merged 2 commits intomainfrom
warning-status
Mar 4, 2026
Merged

Create AddStatusWarning helper#756
kabicin merged 2 commits intomainfrom
warning-status

Conversation

@kabicin
Copy link
Collaborator

@kabicin kabicin commented Mar 4, 2026

What this PR does / why we need it?:

  • Adds a status warnings only if it is not already stored in the ReconcilerBase, Updates one that already exists

Does this PR introduce a user-facing change?

  • User guide
  • CHANGELOG.md

Which issue(s) this PR fixes:

Fixes #

break
}
}
if index != -1 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kabicin Should this be if index == -1 instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right thanks

@kabicin kabicin marked this pull request as ready for review March 4, 2026 18:14
Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kabicin Looks good. Thank you.

@kabicin kabicin merged commit a271abc into main Mar 4, 2026
@kabicin kabicin deleted the warning-status branch March 4, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants