test: correct isinstance check in webhook integration test#662
Merged
Conversation
The `_get_finished_run_id` helper was checking `isinstance(run, ListOfRuns)` after calling `.call()`, which returns a `Run` object, not `ListOfRuns`. This caused flaky failures whenever no prior successful runs existed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #662 +/- ##
==========================================
+ Coverage 96.45% 96.59% +0.13%
==========================================
Files 45 45
Lines 4318 4318
==========================================
+ Hits 4165 4171 +6
+ Misses 153 147 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_webhook_create_and_getintegration test_get_finished_run_idhelper incorrectly assertedisinstance(run, ListOfRuns)after calling.call(), which returns aRunobject — causing failures when no prior successful runs existed for the hello-world actorTest plan
isinstance(run, Run))🤖 Generated with Claude Code