Skip to content

test: correct isinstance check in webhook integration test#662

Merged
vdusek merged 1 commit intomasterfrom
fix/flaky-webhook-integration-test
Mar 6, 2026
Merged

test: correct isinstance check in webhook integration test#662
vdusek merged 1 commit intomasterfrom
fix/flaky-webhook-integration-test

Conversation

@vdusek
Copy link
Contributor

@vdusek vdusek commented Mar 6, 2026

Summary

  • Fix flaky test_webhook_create_and_get integration test
  • The _get_finished_run_id helper incorrectly asserted isinstance(run, ListOfRuns) after calling .call(), which returns a Run object — causing failures when no prior successful runs existed for the hello-world actor

Test plan

  • Verify the fix by inspecting the corrected assertion (isinstance(run, Run))
  • Re-run integration tests to confirm the flaky test passes consistently

🤖 Generated with Claude Code

The `_get_finished_run_id` helper was checking `isinstance(run, ListOfRuns)`
after calling `.call()`, which returns a `Run` object, not `ListOfRuns`.
This caused flaky failures whenever no prior successful runs existed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Mar 6, 2026
@vdusek vdusek self-assigned this Mar 6, 2026
@vdusek vdusek requested a review from Pijukatel March 6, 2026 08:31
@github-actions github-actions bot added this to the 135th sprint - Tooling team milestone Mar 6, 2026
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Mar 6, 2026
@vdusek vdusek changed the title fix: correct isinstance check in webhook integration test test: correct isinstance check in webhook integration test Mar 6, 2026
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.59%. Comparing base (21f2665) to head (2550044).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
+ Coverage   96.45%   96.59%   +0.13%     
==========================================
  Files          45       45              
  Lines        4318     4318              
==========================================
+ Hits         4165     4171       +6     
+ Misses        153      147       -6     
Flag Coverage Δ
integration 94.74% <ø> (+0.27%) ⬆️
unit 78.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek merged commit 57a55d6 into master Mar 6, 2026
26 checks passed
@vdusek vdusek deleted the fix/flaky-webhook-integration-test branch March 6, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants