Skip to content

[SPARK-55782][UI] Replace CSS float right with Bootstrap 5 float-end utility#54615

Open
yaooqinn wants to merge 2 commits intoapache:masterfrom
yaooqinn:SPARK-55782
Open

[SPARK-55782][UI] Replace CSS float right with Bootstrap 5 float-end utility#54615
yaooqinn wants to merge 2 commits intoapache:masterfrom
yaooqinn:SPARK-55782

Conversation

@yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Mar 4, 2026

What changes were proposed in this pull request?

Replaces 2 float: right CSS declarations in webui.css with Bootstrap 5 float-end utility class on the corresponding HTML elements.

CSS changes:

  • a.link: removed float: right
  • span.expand-details: removed float: right

Scala changes (4 files, 6 elements):

  • MasterPage.scala: 2 link anchors added float-end
  • AllJobsPage.scala: 1 link anchor added float-end
  • StageTable.scala: 1 link anchor + 1 expand-details span added float-end
  • UIUtils.scala: 1 expand-details span added float-end

Why are the changes needed?

Aligns with Bootstrap 5 conventions — using utility classes instead of custom CSS for layout. Part of SPARK-55760 (Spark Web UI Modernization).

Does this PR introduce any user-facing change?

No. Visual appearance is identical.

How was this patch tested?

Compilation verified. float-end produces the same float: right !important behavior as the removed CSS rules.

Was this patch authored or co-authored using generative AI tooling?

Yes, co-authored with GitHub Copilot.

yaooqinn and others added 2 commits March 4, 2026 11:12
Replace inline CSS styles with Bootstrap 5 utility classes across Spark Web UI Scala files.

**Conversions:**
- `display: flex; align-items: center` → `d-flex align-items-center`
- `display: inline-block` / `display: inline` → `d-inline-block` / `d-inline`
- `vertical-align: bottom/middle` → `align-bottom` / `align-middle`
- `text-decoration: none` → `text-decoration-none`
- `white-space: nowrap` → `text-nowrap`
- `margin-right: 15px` → `me-3`
- `margin-bottom: 0` → `mb-0`
- `padding-right: 4px` → `pe-1`
- `overflow: auto; padding: 5px` → `overflow-auto p-1`
- `overflow: hidden; text-overflow: ellipsis` → `overflow-hidden text-truncate`
- `cursor: pointer` → `cursor-pointer` (new utility in webui.css)

**Files changed (10):**
- UIUtils.scala, PagedTable.scala, StagePage.scala, DriverLogPage.scala
- ExecutorThreadDumpPage.scala, MasterPage.scala, 3 LogPage variants
- webui.css (added cursor-pointer utility)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace float: right in webui.css with Bootstrap 5 float-end utility class.

- Removed float: right from a.link and span.expand-details CSS rules
- Added float-end class to 6 HTML elements across MasterPage, AllJobsPage, StageTable, UIUtils

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants