[SPARK-55772][UI] Replace jQuery show/hide with Bootstrap 5 d-none utility class#54613
Closed
yaooqinn wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-55772][UI] Replace jQuery show/hide with Bootstrap 5 d-none utility class#54613yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn wants to merge 1 commit intoapache:masterfrom
Conversation
…ility class
Replace jQuery `.show()`, `.hide()`, `.toggle()`, and inline `style="display:none"` with Bootstrap 5 `d-none` utility class across the Spark Web UI.
**JS changes (5 files):**
- `environmentpage.js`: `.show()`/`.hide()` → `.removeClass('d-none')`/`.addClass('d-none')`
- `stagepage.js`: 6 `.show()`/`.hide()` calls → `d-none` class toggling
- `executorspage.js`: `.hide()`/`.show()` and `.toggle()` → `d-none` class
- `streaming-page.js`: `.toggle('collapsed')` → `.toggleClass('d-none')`
- `log-view.js`: `.css('display', ...)` → `d-none` class
**Scala changes (6 files):**
- 4 LogPage variants + UIUtils + StreamingPage: `style="display:none"` → `class="d-none"`
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dongjoon-hyun
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replaces jQuery
.show(),.hide(),.toggle(),.css("display", ...), and inlinestyle="display:none"with Bootstrap 5d-noneutility class across the Spark Web UI.JS changes (5 files):
environmentpage.js:.show()/.hide()→.removeClass("d-none")/.addClass("d-none")stagepage.js: 6.show()/.hide()calls for speculation summary and accumulator tableexecutorspage.js:.hide()/.show()for active-process-container and flamegraph togglestreaming-page.js:.toggle("collapsed")→.toggleClass("d-none")log-view.js:.css("display", ...)→d-noneclass add/removeScala changes (6 files):
style="display: none;"→class="d-none"UIUtils.scala: dag-viz-metadata divStreamingPage.scala: inputs-table rowWhy are the changes needed?
Using
d-noneconsistently across the codebase:.show()/.hide()which manipulate inline stylesPart of SPARK-55760 (Spark Web UI Modernization).
Does this PR introduce any user-facing change?
No. Visibility behavior is identical.
How was this patch tested?
lint-jspassesscalastylepassesWas this patch authored or co-authored using generative AI tooling?
Yes, co-authored with GitHub Copilot.