Open
Conversation
added 2 commits
March 8, 2026 18:12
Contributor
BewareMyPower
left a comment
There was a problem hiding this comment.
This still print debug logs, which checks the Logger::isEnabled after the client is closed. Technically, we should not access the logger after the client is closed.
added 2 commits
March 10, 2026 08:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #530
Motivation
When Python/C++ bindings create C++ ProducerImpl/ConsumerImpl objects and the Python interpreter shuts down, C++ destructors may run after the client is already closed.
This causes logging attempts during static/global cleanup which is dangerous because logging systems might already be torn down. Issue #530 identified this problem: "We
should not print logs after client is closed".
Modifications
Verifying this change
This change is already covered by existing tests, such as ProducerTest and ConsumerTest which exercise producer/consumer lifecycle.