HDFS-17684. Add LocalBytesRead and LocalBytesWritten metrics to DataNode.#8317
Open
balodesecurity wants to merge 1 commit intoapache:trunkfrom
Open
HDFS-17684. Add LocalBytesRead and LocalBytesWritten metrics to DataNode.#8317balodesecurity wants to merge 1 commit intoapache:trunkfrom
balodesecurity wants to merge 1 commit intoapache:trunkfrom
Conversation
…ode. Track per-client-locality byte counts separately so operators can distinguish local vs remote traffic volume in DataNode metrics dashboards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataNodeMetricsalready tracksWritesFromLocalClient/WritesFromRemoteClient(count only) andRemoteBytesRead/RemoteBytesWritten(bytes), but there is no byte-level metric for local client reads/writes.This patch adds two new
MutableCounterLongmetrics:LocalBytesReadLocalBytesWrittenThese are incremented in
incrReadsFromClient(boolean local, long size)andincrWritesFromClient(boolean local, long size)alongside the existing remote-bytes counters, so no call-site changes are required.Changes
DataNodeMetrics.java— addedlocalBytesRead/localBytesWrittenfields and updatedincrReadsFromClient/incrWritesFromClientto increment themTestDataNodeMetrics.java— addedtestLocalBytesMetricswhich spins up aMiniDFSCluster, writes then reads a file from the local client, and asserts both new counters are positive while the remote-bytes counters remain zeroTesting
TestDataNodeMetricstestLocalBytesMetrics