Add CI check for crates.io patches#1407
Merged
timsaucer merged 1 commit intoapache:mainfrom Mar 4, 2026
Merged
Conversation
nuno-faria
approved these changes
Mar 2, 2026
Contributor
nuno-faria
left a comment
nuno-faria
left a comment
There was a problem hiding this comment.
LGTM. The CI on PRs will still run normally right?
| # We cannot publish to crates.io with any patches in the below section. Developers | ||
| # must remove any entries in this section before creating a release candidate. | ||
| [patch.crates-io] | ||
| # datafusion = { git = "https://github.com/apache/datafusion.git", rev = "6713439497561fa74a94177e5b8632322fb7cea5" } |
Contributor
There was a problem hiding this comment.
Is this last line meant to be committed?
Contributor
There was a problem hiding this comment.
L98 is commented out. i assume it wont be parsed by tomllib 😄
Member
Author
There was a problem hiding this comment.
Yes, exactly. This is intentional to show as an example and commented out to show it still passes CI
Contributor
|
This is quite exciting to see -- specifically that we are working to improve the velocity of datafusion-python 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1399
Rationale for this change
This PR will cause CI to fail for release candidates with release patches in this repository.
What changes are included in this PR?
Add CI script.
Add example section to Cargo.toml with comment
Are there any user-facing changes?
None, CI only