GH-49250: [C++][FlightRPC] ODBC: SQLError for macOS#49251
Merged
lidavidm merged 1 commit intoapache:mainfrom Mar 6, 2026
Merged
GH-49250: [C++][FlightRPC] ODBC: SQLError for macOS#49251lidavidm merged 1 commit intoapache:mainfrom
lidavidm merged 1 commit intoapache:mainfrom
Conversation
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
CI: Extra: C++
alinaliBQ
force-pushed
the
gh-49250-sql-error
branch
from
76d06af to
039954a
Compare
alinaliBQ
commented
Feb 12, 2026
github-actions
bot
added
awaiting committer review
justing-bq
force-pushed
the
gh-49250-sql-error
branch
from
039954a to
136a31a
Compare
lidavidm
approved these changes
Feb 23, 2026
github-actions
bot
added
awaiting merge
Disable `SQLGetConnectOption` on macOS as it isn't required by macOS Excel to fetch data. Locally `debug/arrow-flight-sql-odbc-test "--gtest_filter=*.TestConnect:Error*.*"` pass with no issues. Co-Authored-By: justing-bq <justin.gossett@improving.com>
alinaliBQ
force-pushed
the
gh-49250-sql-error
branch
from
136a31a to
fd73fcc
Compare
Collaborator
Author
|
@lidavidm I have rebased this branch onto `main. This PR is ready for review |
lidavidm
approved these changes
Mar 6, 2026
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f83c554. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#49250
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
N/A