fix(process): prevent orphaned opencode subprocesses on shutdown#15924
Merged
fix(process): prevent orphaned opencode subprocesses on shutdown#15924
Conversation
Previously, MCP servers like chrome-devtools-mcp that spawn grandchild processes (e.g. Chrome browser instances) would leave those processes orphaned when the connection closed. Now all descendant processes are properly terminated, preventing resource leaks and zombie processes.
The worker was racing instance disposal against a 5s timeout, which could leave active sessions in an inconsistent state. Now waits 10s to ensure graceful cleanup completes before shutting down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUN_BE_BUNopencode subprocesses) with timeout-bounded close and process-tree termination fallbackRoot Cause
Changes
packages/opencode/src/cli/cmd/tui/thread.tsstop()functionworker.terminate()packages/opencode/src/mcp/index.tscloseClient()helper that:closeClient()consistently on dispose, reconnect/replace, disconnect, and failed startup/tool-list pathsTesting