fix(tool): correct misleading "No files found" message in grep tool#15861
Open
saurav61091 wants to merge 3 commits intoanomalyco:devfrom
Open
fix(tool): correct misleading "No files found" message in grep tool#15861saurav61091 wants to merge 3 commits intoanomalyco:devfrom
saurav61091 wants to merge 3 commits intoanomalyco:devfrom
Conversation
The grep tool searches for pattern matches within files, but displayed "No files found" when no matches were found. This is misleading since it implies a file search failure rather than zero pattern matches. Changed to "No matches found" for consistency with the success message which says "Found N matches".
Update the test assertion to match the corrected output message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #15860
Type of change
What does this PR do?
The grep tool searches for regex pattern matches within files using ripgrep. When no matches are found, it returned "No files found" which is misleading — it implies the file search failed, not that the pattern had zero matches.
Changed the message to "No matches found" on both code paths (ripgrep exit code 1 on line 70, and empty parsed results on line 114). This is consistent with the success message on line 119 which says "Found N matches".
How did you verify your code works?
bun run buildpassespackages/opencode/src/tool/grep.tsScreenshots / recordings
N/A — no UI changes, only tool output text.
Checklist