fix(opencode): retry transient provider failures and tool-call diff/input errors#15850
Open
pkellyuk wants to merge 3 commits intoanomalyco:devfrom
Open
fix(opencode): retry transient provider failures and tool-call diff/input errors#15850pkellyuk wants to merge 3 commits intoanomalyco:devfrom
pkellyuk wants to merge 3 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
Added follow-up commit 05f1bb8 for another real-world tool-call failure:\n\n- repairs write calls where model outputs filepath/path aliases instead of filePath\n- handles tool-error while tool state is pending (prevents fallback to generic \Tool execution aborted)\n\nNew regression test added in \session/llm.test.ts\ for the \�xpected string, received undefined\ filePath case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #15851
Closes #15906
Type of change
What does this PR do?
This PR fixes two cases where sessions stopped instead of recovering:
ECONNREFUSED,ECONNRESET, nested socket causes).Invalid diff: now finding less tool calls!by marking them retryable.JSON parsing failed: Text: ...) inexperimental_repairToolCallso tool execution can continue.Together these changes reduce hard-aborts in tool-heavy sessions and route recoverable failures into the existing retry path.
How did you verify your code works?
From
packages/opencode:bun test test/session/retry.test.ts test/session/llm.test.tsAdded/updated regression tests for:
ECONNREFUSEDand related transient network errorsScreenshots / recordings
N/A (non-UI behavior)
Checklist