Skip to content

build: update dependency @conventional-changelog/git-client to v2#3490

Merged
josephperrott merged 1 commit intoangular:mainfrom
angular-robot:ng-renovate/conventional-changelog-git-client-2-x
Mar 6, 2026
Merged

build: update dependency @conventional-changelog/git-client to v2#3490
josephperrott merged 1 commit intoangular:mainfrom
angular-robot:ng-renovate/conventional-changelog-git-client-2-x

Conversation

@angular-robot
Copy link
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@conventional-changelog/git-client (source) 1.0.12.6.0 age adoption passing confidence

Release Notes

conventional-changelog/conventional-changelog (@​conventional-changelog/git-client)

v2.6.0

Features

v2.5.1

Bug Fixes
  • checkout methods format fix (993c1fd)

v2.5.0

Features

v2.4.0

Features
  • git tags params were added (f7e4f68)

v2.3.0

Features
  • init method was added, allowEmpty param was added to commit method (5724d53)

v2.2.0

Features
  • tags and followTags params are added to push method (61a1e34)

v2.1.0

Features
  • getDefaultBranch was added (1518d81)
  • safe parameter for verify method (2f07b29)
  • verify and getConfig methods are added to GitClient (#​1348) (3ba2198)
Bug Fixes
  • cleanup branch name in getDefaultBranch (7c80d81)
  • throw error only when spawned child exits with non-zero result (0253545)

v2.0.0

⚠ BREAKING CHANGES
  • git-client: ability to pass additional git params is removed
Bug Fixes
  • conventional-changelog-writer,git-client: move @types/semver to dev dependencies (#​1268) (4ca2b86)
  • git-client: ability to pass additional git params is removed by security reasons (#​1325) (d95c9ff)
  • git-client: close the generator used by getLastSemverTag (#​1281) (a1764d6)
  • git-client: match semver better in unstable tag regex (#​1277) (9f0895b)

  • If you want to rebase/retry this PR, check this box

See associated pull request for more information.
@angular-robot angular-robot added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] labels Mar 6, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @conventional-changelog/git-client dependency to v2. This is a major update which includes a significant breaking change: the ability to pass additional git parameters has been removed for security reasons. While reviewing the related files, I discovered a potential bug in ng-dev/utils/version-check.ts concerning the parsing of pnpm-lock.yaml. The logic for extracting the @angular/ng-dev version appears to be incorrect and may not function as intended. I'm noting this here as the file is not part of the diff and cannot be commented on directly.

Note: Security Review did not run due to the size of the PR.

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott merged commit 6659b1f into angular:main Mar 6, 2026
9 checks passed
@josephperrott
Copy link
Member

This PR was merged into the repository. The changes were merged into the following branches:

@angular-robot angular-robot deleted the ng-renovate/conventional-changelog-git-client-2-x branch March 6, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants