build: update dependency aspect_rules_js to v3#3485
Open
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Open
build: update dependency aspect_rules_js to v3#3485alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
angular-robot
bot
added
the
area: build & ci
alan-agius4
added
the
action: blocked
alan-agius4
force-pushed
the
pr-takeover-3483
branch
from
a784a8e to
274e8c3
Compare
alan-agius4
removed
the
action: blocked
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates aspect_rules_js to v3 and applies the necessary code migrations. The changes, including updating from aspect_bazel_lib to bazel_lib and adjusting how runfiles environment variables are handled, are generally well-executed. I've identified a few areas for improvement, including a potentially unintentional dependency downgrade and some minor inconsistencies in the TypeScript code. My detailed feedback is in the comments below.
alan-agius4
force-pushed
the
pr-takeover-3483
branch
from
274e8c3 to
6228dff
Compare
See associated pull request for more information.
alan-agius4
force-pushed
the
pr-takeover-3483
branch
from
7d391e7 to
f11677a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See associated pull request for more information.