build: update dependency aspect_rules_js to v3 (main)#32692
build: update dependency aspect_rules_js to v3 (main)#32692angular-robot wants to merge 1 commit intoangular:mainfrom
Conversation
See associated pull request for more information.
angular-robot
added
action: merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This PR updates aspect_rules_js to v3. This is a major version update which introduces breaking changes. The most significant one seems to be the handling of pnpm. The MODULE.bazel.lock file changes indicate that the pnpm module extension is no longer used in the same way, which will likely break the build given the current MODULE.bazel configuration. Please see my comment for details on how to address this.
| bazel_dep(name = "yq.bzl", version = "0.3.5") | ||
| bazel_dep(name = "rules_nodejs", version = "6.7.3") | ||
| bazel_dep(name = "aspect_rules_js", version = "2.9.2") | ||
| bazel_dep(name = "aspect_rules_js", version = "3.0.1") |
There was a problem hiding this comment.
Upgrading aspect_rules_js to v3 is a major change that seems to have breaking changes regarding pnpm setup. The MODULE.bazel.lock file changes show that the pnpm module extension is no longer generating a repository, which will likely cause a build failure because of the use_repo(pnpm, "pnpm") call on line 122.
Please check the aspect_rules_js v3 migration guide. The pnpm setup block on lines 116-122 might need to be removed or updated.
1 participant
This PR contains the following updates:
2.9.2→3.0.1