Fixes build after androidx.xr.compose:compose update to 1.0.0-alpha11#203
Fixes build after androidx.xr.compose:compose update to 1.0.0-alpha11#203wintezz wants to merge 2 commits intoandroid:mainfrom
androidx.xr.compose:compose update to 1.0.0-alpha11#203Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on adapting the project to the breaking changes introduced by the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully updates androidx.xr.compose to 1.0.0-alpha11 and addresses the resulting breaking changes. The changes primarily involve removing custom implementations and workarounds for SpatialConfiguration and SpatialCapabilities, which are now unnecessary. A significant number of dependencies have also been updated across the project, including Gradle, Spotless, and various AndroidX and third-party libraries. The code is now cleaner and relies on the official platform APIs. My review identified one potential issue regarding the update of the Guava dependency from the -android to the -jre artifact, which could have implications for Android compatibility.
| googleOssPlugin = "0.10.10" | ||
| guava = "33.5.0-android" | ||
| hiltAndroid = "2.59" | ||
| guava = "33.5.0-jre" |
There was a problem hiding this comment.
The Guava dependency has been changed from the -android artifact to the -jre artifact. The -jre artifact is intended for general Java projects and may contain APIs not available on all Android versions, which can lead to runtime crashes on older devices if core library desugaring is not correctly configured. For Android projects, it is recommended to use the -android artifact, which is specifically tailored for Android compatibility. If this change is not required by another dependency update, consider reverting to the -android artifact.
| guava = "33.5.0-jre" | |
| guava = "33.5.0-android" |
- Remove custom implementations of sealed interfaces SpatialConfiguration and SpatialCapabilities - Delete workaround composition locals for Preview (fixed in library)
Problem:
The update to alpha11 introduced breaking changes:
SpatialConfigurationandSpatialCapabilitiesbecamesealed interfaces, making custom implementations impossibleb/441901724(Preview crashing on XR CompositionLocal access) i think is fixed in the librarySolution:
Removed all custom implementations:
Removed workarounds:
Removed SupportsFullSpaceModeRequestProvider
Switched to using official
androidx.xr.compose.platformResult
Related PR:
#195