atmel-samd SPI: don't mark_deinit before resetting pin#10874
Open
dhalbert wants to merge 1 commit intoadafruit:10.1.xfrom
Open
atmel-samd SPI: don't mark_deinit before resetting pin#10874dhalbert wants to merge 1 commit intoadafruit:10.1.xfrom
dhalbert wants to merge 1 commit intoadafruit:10.1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
atmel-samdSPIobjects were not being deinited properly. The clock pin was set toNO_PINprematurely, and the pin The second time this program ran, after a ctrl-C and restart, it would stop withSCK in use.It has to be being used by a
FourWire; just creatingspidoes not provoke the bug.FourWiremakes the SPI bus pins "never reset", and the "never reset" state was not being cleared.The
// Mark as deinit early in case we are used in an interrupt.should not be necessary. That was taken fromespressif, and I don't believe it is applicable here.I looked at the other ports and I didn't see a similar bug, so I think this is just
atmel-samd.