Conversation
sacOO7
reviewed
Jun 12, 2025
d10e385 to
3336d98
Compare
36792eb to
cdb9d58
Compare
cdb9d58 to
f4dd5d4
Compare
f4dd5d4 to
b4d8e4d
Compare
b4d8e4d to
948ad9b
Compare
bebe5fa to
5a6893a
Compare
948ad9b to
39111b8
Compare
39111b8 to
8a7c38e
Compare
8a7c38e to
2335a1d
Compare
dd25dca to
fc46aed
Compare
bfcf05b to
b3e06dc
Compare
lawrence-forooghian
approved these changes
Sep 5, 2025
sacOO7
approved these changes
Sep 5, 2025
Collaborator
sacOO7
left a comment
There was a problem hiding this comment.
LGTM ( You can recheck all review comments in case )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the spec equivalent of the object sync sequence handling in ably-js https://github.com/ably/ably-js/blob/main/src/plugins/objects/objects.ts#L215
Resolves PUB-1041