Conversation
…Mocha/Chai test framework
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughFour test suites are removed: apps:update, auth:keys:list, channel-rule:create, and integrations:create CLI commands. These .skip test files containing mocked API interactions, parameter validation, and error handling scenarios are deleted entirely. Total removal: 1,930 lines. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
All 4
.skiptest files were legacy dead code from the original Mocha/Chai test framework that was never cleaned up after the vitest migration:.skipFiletest/unit/commands/channel-rule/create.test.ts.skiptest/unit/commands/channel-rule/create.test.ts+test/unit/commands/apps/channel-rules/create.test.tstest/unit/commands/apps/update.test.ts.skiptest/unit/commands/apps/update.test.tstest/unit/commands/integrations/create.test.ts.skiptest/unit/commands/integrations/create.test.tstest/unit/commands/auth/keys/list.test.ts.skiptest/unit/commands/auth/keys/list.test.tsThese files were originally disabled in commit
a9a480cbecause they had nock mocking incompatibilities with the old@oclif/test+ Mocha/Chai test runner. Subsequently, the project migrated to vitest (commit3503e12), and new vitest-based test files were written for each of these commands, making the.skipfiles completely redundant.They were never executed, never linted, and used stale patterns (e.g.,
channelNamespaceinstead ofid). Keeping them around only causes confusion for reviewers and contributors.Related to #98
Summary by CodeRabbit
Note
Cursor Bugbot is generating a summary for commit e7cdc96. Configure here.