Skip to content

Cleanup - redundant tests#143

Merged
sacOO7 merged 1 commit intomainfrom
cleanup/redundant-tests
Mar 3, 2026
Merged

Cleanup - redundant tests#143
sacOO7 merged 1 commit intomainfrom
cleanup/redundant-tests

Conversation

@sacOO7
Copy link
Contributor

@sacOO7 sacOO7 commented Mar 3, 2026

All 4 .skip test files were legacy dead code from the original Mocha/Chai test framework that was never cleaned up after the vitest migration:

Removed .skip File Active Vitest Replacement
test/unit/commands/channel-rule/create.test.ts.skip test/unit/commands/channel-rule/create.test.ts + test/unit/commands/apps/channel-rules/create.test.ts
test/unit/commands/apps/update.test.ts.skip test/unit/commands/apps/update.test.ts
test/unit/commands/integrations/create.test.ts.skip test/unit/commands/integrations/create.test.ts
test/unit/commands/auth/keys/list.test.ts.skip test/unit/commands/auth/keys/list.test.ts

These files were originally disabled in commit a9a480c because they had nock mocking incompatibilities with the old @oclif/test + Mocha/Chai test runner. Subsequently, the project migrated to vitest (commit 3503e12), and new vitest-based test files were written for each of these commands, making the .skip files completely redundant.

They were never executed, never linted, and used stale patterns (e.g., channelNamespace instead of id). Keeping them around only causes confusion for reviewers and contributors.

Related to #98

Summary by CodeRabbit

  • Tests
    • Removed unused test suite files. No end-user features or functionality have been changed.

Note

Cursor Bugbot is generating a summary for commit e7cdc96. Configure here.

@vercel
Copy link

vercel bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cli-web-cli Ready Ready Preview, Comment Mar 3, 2026 1:45pm

Request Review

@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

Walkthrough

Four test suites are removed: apps:update, auth:keys:list, channel-rule:create, and integrations:create CLI commands. These .skip test files containing mocked API interactions, parameter validation, and error handling scenarios are deleted entirely. Total removal: 1,930 lines.

Changes

Cohort / File(s) Summary
Test Suite Removals
test/unit/commands/apps/update.test.ts.skip, test/unit/commands/auth/keys/list.test.ts.skip, test/unit/commands/channel-rule/create.test.ts.skip, test/unit/commands/integrations/create.test.ts.skip
Complete removal of four CLI command test files covering successful operations, JSON output validation, authentication/error handling (401, 403, 404, 500), parameter validation, edge cases, and network error scenarios. All mocked interactions against the Ably Control API are deleted.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Four test files hop away,
Into the digital delay,
No more mocks or nock shall play,
A cleaner suite marks the day!
Thump thump goes my little paw! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change—removal of redundant, legacy test files that were disabled after the vitest migration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cleanup/redundant-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sacOO7
Copy link
Contributor Author

sacOO7 commented Mar 3, 2026

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sacOO7 sacOO7 marked this pull request as ready for review March 3, 2026 13:55
@sacOO7 sacOO7 merged commit d2bc376 into main Mar 3, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants