Skip to content

sync: dev to extern-contrib#918

Merged
PythonSmall-Q merged 12 commits intoextern-contribfrom
dev
Feb 24, 2026
Merged

sync: dev to extern-contrib#918
PythonSmall-Q merged 12 commits intoextern-contribfrom
dev

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 23, 2026

sync-branches: New code has just landed in dev, so let's bring extern-contrib up to speed!


Summary by cubic

Allow UpdateVersion to run on edited PRs even if the last commit is from a bot, and gate WebSocket toasts by per-feature popup settings. Bumps version to 3.2.2 with updated release notes.

  • Bug Fixes
    • UpdateVersion: exclude all bot actors in the workflow and allow edited events in the script so PR title/body edits still update Update.json without loops.
    • WebSocket toasts: gate bbs_mention/mail_mention by BBSPopup/MessagePopup to match polling behavior.

Written for commit d6ecb25. Summary will update on new commits.

The last-commit-author guard now only exits for non-edited events,
so PR title/body changes still update Update.json metadata even
when the branch tip is a github-actions[bot] commit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 23, 2026

Deploying xmoj-script-dev-channel with  Cloudflare Pages  Cloudflare Pages

Latest commit: d6ecb25
Status: ✅  Deploy successful!
Preview URL: https://09f975e3.xmoj-script-dev-channel.pages.dev

View logs

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="Update/UpdateVersion.js">

<violation number="1" location="Update/UpdateVersion.js:18">
P2: The guard still skips for any action other than `edited`, which contradicts the comment that says only synchronize events should be skipped. This can prevent metadata updates on non-synchronize actions (e.g., `opened`), even though they should be allowed per the new behavior.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

console.log("Last commit author: " + lastCommitAuthor);
if (lastCommitAuthor === "github-actions[bot]") {
console.log("Event action : " + eventAction);
if (lastCommitAuthor === "github-actions[bot]" && eventAction !== "edited") {
Copy link

@cubic-dev-ai cubic-dev-ai bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The guard still skips for any action other than edited, which contradicts the comment that says only synchronize events should be skipped. This can prevent metadata updates on non-synchronize actions (e.g., opened), even though they should be allowed per the new behavior.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At Update/UpdateVersion.js, line 18:

<comment>The guard still skips for any action other than `edited`, which contradicts the comment that says only synchronize events should be skipped. This can prevent metadata updates on non-synchronize actions (e.g., `opened`), even though they should be allowed per the new behavior.</comment>

<file context>
@@ -8,9 +8,14 @@ execSync("gh pr checkout " + PRNumber);
 console.log("Last commit author: " + lastCommitAuthor);
-if (lastCommitAuthor === "github-actions[bot]") {
+console.log("Event action       : " + eventAction);
+if (lastCommitAuthor === "github-actions[bot]" && eventAction !== "edited") {
     console.log("Last commit was made by github-actions[bot]. Skipping to prevent infinite loop.");
     process.exit(0);
</file context>
Suggested change
if (lastCommitAuthor === "github-actions[bot]" && eventAction !== "edited") {
if (lastCommitAuthor === "github-actions[bot]" && eventAction === "synchronize") {
Fix with Cubic

boomzero and others added 10 commits February 23, 2026 20:12
The WebSocket handler called CreateAndShowBBSMentionToast and
CreateAndShowMailMentionToast unconditionally, ignoring the user's
BBSPopup/MessagePopup toggle. This made behavior differ from the
polling fallback, which already checks UtilityEnabled() per type.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Gate WebSocket toast notifications by per-feature popup settings
@hendragon-bot hendragon-bot bot added GitHub-related user-script This issue or pull request is related to the main user script update-script Related to our update infrastructure! labels Feb 23, 2026
Exclude all bot actors (not just github-actions[bot]) from triggering
the UpdateVersion workflow, preventing loops from AI code review bots.
Allow edited events through the script-level guard so PR title/body
changes still update Update.json metadata.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@PythonSmall-Q PythonSmall-Q merged commit 6e056e9 into extern-contrib Feb 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GitHub-related size/M update-script Related to our update infrastructure! user-script This issue or pull request is related to the main user script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants