sync: dev to extern-contrib#918
Merged
PythonSmall-Q merged 12 commits intoextern-contribfrom Feb 24, 2026
Merged
Conversation
The last-commit-author guard now only exits for non-edited events, so PR title/body changes still update Update.json metadata even when the branch tip is a github-actions[bot] commit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deploying xmoj-script-dev-channel with
|
| Latest commit: |
d6ecb25
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09f975e3.xmoj-script-dev-channel.pages.dev |
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="Update/UpdateVersion.js">
<violation number="1" location="Update/UpdateVersion.js:18">
P2: The guard still skips for any action other than `edited`, which contradicts the comment that says only synchronize events should be skipped. This can prevent metadata updates on non-synchronize actions (e.g., `opened`), even though they should be allowed per the new behavior.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| console.log("Last commit author: " + lastCommitAuthor); | ||
| if (lastCommitAuthor === "github-actions[bot]") { | ||
| console.log("Event action : " + eventAction); | ||
| if (lastCommitAuthor === "github-actions[bot]" && eventAction !== "edited") { |
There was a problem hiding this comment.
P2: The guard still skips for any action other than edited, which contradicts the comment that says only synchronize events should be skipped. This can prevent metadata updates on non-synchronize actions (e.g., opened), even though they should be allowed per the new behavior.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At Update/UpdateVersion.js, line 18:
<comment>The guard still skips for any action other than `edited`, which contradicts the comment that says only synchronize events should be skipped. This can prevent metadata updates on non-synchronize actions (e.g., `opened`), even though they should be allowed per the new behavior.</comment>
<file context>
@@ -8,9 +8,14 @@ execSync("gh pr checkout " + PRNumber);
console.log("Last commit author: " + lastCommitAuthor);
-if (lastCommitAuthor === "github-actions[bot]") {
+console.log("Event action : " + eventAction);
+if (lastCommitAuthor === "github-actions[bot]" && eventAction !== "edited") {
console.log("Last commit was made by github-actions[bot]. Skipping to prevent infinite loop.");
process.exit(0);
</file context>
Suggested change
| if (lastCommitAuthor === "github-actions[bot]" && eventAction !== "edited") { | |
| if (lastCommitAuthor === "github-actions[bot]" && eventAction === "synchronize") { |
The WebSocket handler called CreateAndShowBBSMentionToast and CreateAndShowMailMentionToast unconditionally, ignoring the user's BBSPopup/MessagePopup toggle. This made behavior differ from the polling fallback, which already checks UtilityEnabled() per type. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Gate WebSocket toast notifications by per-feature popup settings
Exclude all bot actors (not just github-actions[bot]) from triggering the UpdateVersion workflow, preventing loops from AI code review bots. Allow edited events through the script-level guard so PR title/body changes still update Update.json metadata. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync-branches: New code has just landed in dev, so let's bring extern-contrib up to speed!
Summary by cubic
Allow UpdateVersion to run on edited PRs even if the last commit is from a bot, and gate WebSocket toasts by per-feature popup settings. Bumps version to 3.2.2 with updated release notes.
Written for commit d6ecb25. Summary will update on new commits.