Fix contest ranking table styling for dark mode#916
Merged
Conversation
Clear inline background/color styles from XMOJ server on header and data rows so Bootstrap dark theme applies correctly. Force black background with white text on all header cells including problem letter links. Also fix rgb -> rgba for solved cell background alpha channel, and add missing text color styling for contestrank-correct.php cells. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="package.json">
<violation number="1" location="package.json:3">
P2: Manual version bump in package.json conflicts with the automated versioning workflow; this should be handled by UpdateVersion.js instead of editing by hand.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| { | ||
| "name": "xmoj-script", | ||
| "version": "3.2.0", | ||
| "version": "3.2.1", |
There was a problem hiding this comment.
P2: Manual version bump in package.json conflicts with the automated versioning workflow; this should be handled by UpdateVersion.js instead of editing by hand.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 3:
<comment>Manual version bump in package.json conflicts with the automated versioning workflow; this should be handled by UpdateVersion.js instead of editing by hand.</comment>
<file context>
@@ -1,6 +1,6 @@
{
"name": "xmoj-script",
- "version": "3.2.0",
+ "version": "3.2.1",
"description": "an improvement script for xmoj.tech",
"main": "AddonScript.js",
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix broken styling on contest ranking pages (
contestrank-oi.phpandcontestrank-correct.php) where XMOJ server inline styles caused white/light backgrounds and unreadable text in dark mode.Implementation
Changelog
<a>links), removingbgcolorattributes and using!importantto prevent Bootstrap overridesbackgroundColorandcolorfrom the XMOJ server so Bootstrap's dark theme applies correctlybackgroundColoron<tr>elementsrgb()→rgba()for background with alpha channelstyle.colorfor dark mode text visibilityConfirmation
I have read the contributor's guide and I'm making this PR to the
devbranch.I have added code comments (if necessary) and tested my changes.
I am willing to maintain this change in the future.
This submission is compatible with GPL v3.0.
I have squashed all insignificant commits.
There is no existing duplicate PR for this.
I believe this change may be valuable to others.
I accept that this submission may not be used and the PR may be closed.
I surrender all ownership claims to the code submitted.
I have read everything above and my PR is ready for review.
🤖 Generated with Claude Code
Summary by cubic
Fixes dark mode styling for contest ranking tables by removing conflicting inline colors and enforcing readable header styles. Improves readability on both OI and Correct ranking pages.
Written for commit ba94e6f. Summary will update on new commits.