Skip to content

Administration: Update .wp-filter component to use new admin color va…#11155

Closed
manishdhorepatil-art wants to merge 1 commit intoWordPress:trunkfrom
manishdhorepatil-art:64788-filter-new-colors
Closed

Administration: Update .wp-filter component to use new admin color va…#11155
manishdhorepatil-art wants to merge 1 commit intoWordPress:trunkfrom
manishdhorepatil-art:64788-filter-new-colors

Conversation

@manishdhorepatil-art
Copy link

@manishdhorepatil-art manishdhorepatil-art commented Mar 4, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/64788

Summary

The .wp-filter component used on the Add Plugins and Add Themes screens
is still using legacy hardcoded color values instead of the new admin
color variables introduced as part of the admin reskin.

This causes visual inconsistencies with the updated admin color system.

Changes

  • Replaced hardcoded color values with the appropriate CSS custom properties:

    • --wp-admin-theme-color
  • Ensured hover, focus, and active states use the new design tokens.

  • No visual changes outside of the filter component.

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @ManishDhorepatil.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props huzaifaalmesbah, manishxdp.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@huzaifaalmesbah
Copy link
Member

Thanks for the PR.
I noticed only var(--wp-admin-theme-color) is used, while the description mentions other variables as well. Could you clarify why?

Also, a similar fix already exists in PR #11153
Is there a reason for opening another PR?

@manishdhorepatil-art
Copy link
Author

@huzaifaalmesbah You’re right — the patch only uses var(--wp-admin-theme-color). The PR description was incorrect in mentioning --wp-admin-theme-color-darker-10 and --wp-admin-border-color. I’ll update the description.

@manishdhorepatil-art
Copy link
Author

I wasn’t aware of PR #11153 when I opened this.

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61832
GitHub commit: e1c433c

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants